Re: [patch] Fix warnings using gcc-4.5 HEAD

Jan Kratochvil
2009-09-10T07:29:15Z

On Thu, 10 Sep 2009 03:48:21 +0200, Joel Brobecker wrote:
> The Ada part seems fine. I'm left wondering if it really brings much
> value to have this in a separate file, rather than added directly to
> enum exp_opcode inside expression.h, especially since other languages
> are now having visibility on these enumerates. But the the benefits
> are not obvious either way to me, so let's not worry about this for now.

OK, I (also) do not have a strict opinion on it.

> Do you want me to look at the rest of the patch as well, or did someone
> (Tom?) look at that already?

Except for the changed comment for OP_EXTENDED0 the whole patch is now
approved, the other part by Tom:
http://sourceware.org/ml/gdb-patches/2009-07/msg00721.html

Going to check it in on weekend if nobody replies.

Thanks,
Jan