Re: [patch] Fix warnings using gcc-4.5 HEAD

Joel Brobecker
2009-09-10T01:48:37Z

> > I'd like Joel to comment on the Ada changes.
>
> Hi Joel, pinging for 7.0, this reply is to:
> http://sourceware.org/ml/gdb-patches/2009-07/msg00721.html

The Ada part seems fine. I'm left wondering if it really brings much
value to have this in a separate file, rather than added directly to
enum exp_opcode inside expression.h, especially since other languages
are now having visibility on these enumerates. But the the benefits
are not obvious either way to me, so let's not worry about this for now.

Do you want me to look at the rest of the patch as well, or did someone
(Tom?) look at that already?

--
Joel