From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20728 invoked by alias); 23 Oct 2010 09:07:52 -0000 Received: (qmail 20716 invoked by uid 22791); 23 Oct 2010 09:07:51 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 23 Oct 2010 09:07:46 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LAQ00G00JTUAQ00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 23 Oct 2010 11:07:44 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.116.216]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LAQ00FPTK0UPR70@a-mtaout22.012.net.il>; Sat, 23 Oct 2010 11:07:44 +0200 (IST) Date: Sat, 23 Oct 2010 09:07:00 -0000 From: Eli Zaretskii Subject: Re: [patch] Add visible flag to breakpoints. In-reply-to: To: pmuldoon@redhat.com Cc: tromey@redhat.com, pedro@codesourcery.com, gdb-patches@sourceware.org, dan@codesourcery.com Reply-to: Eli Zaretskii Message-id: <837hh98efq.fsf@gnu.org> References: <201010081435.15174.pedro@codesourcery.com> <201010162003.41609.pedro@codesourcery.com> <83aam59aot.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00359.txt.bz2 > From: Phil Muldoon > Cc: tromey@redhat.com, pedro@codesourcery.com, gdb-patches@sourceware.org, > dan@codesourcery.com > Date: Fri, 22 Oct 2010 22:37:19 +0100 > > Eli Zaretskii writes: > > >> From: Phil Muldoon > >> Cc: Pedro Alves , gdb-patches@sourceware.org, dan@codesourcery.com > >> Date: Fri, 22 Oct 2010 22:05:30 +0100 > >> > >> I decided to add internal watchpoint support. I've also added the other > >> changes requested. > >> > >> OK? > > > > Thanks. > > > >> -/* Set a breakpoint. This function is shared between CLI and MI > >> +/* Set a breakpoint. This function is shared between CLI and MI > > > > Why did you need to remove one of the two spaces between these > > sentences? > > I didn't, this was an error. Thanks for catching. > > > > >> functions for setting a breakpoint. This function has two major > >> modes of operations, selected by the PARSE_CONDITION_AND_THREAD > >> parameter. If non-zero, the function will parse arg, extracting > >> breakpoint location, address and thread. Otherwise, ARG is just the > >> location of breakpoint, with condition and thread specified by the > >> - COND_STRING and THREAD parameters. Returns true if any breakpoint > >> - was created; false otherwise. */ > >> - > >> + COND_STRING and THREAD parameters. If INTERNAL is non-zero, the > >> + breakpoint number will be allocated from the internal breakpoint > >> + count. Returns true if any breakpoint was created; false > > ^^^ > > And here you have 3 instead of 2. > > Thanks > > >> +@code{maint info breakpoints} command). The optional @var{wp_class} > >> argument defines the class of watchpoint to create, if @var{type} is > >> defined as @code{BP_WATCHPOINT}. > > > > "if @var{type} is @code{BP_WATCHPOINT}" is simpler and more clear, IMO. > > Thanks. > > >> +@defivar Breakpoint visible > >> +This attribute holds the breakpoint's visibility flag---the identifier used to > >> +determine whether the breakpoint is visible to the user when set, or > >> +when the @samp{info breakpoints} command is run. > > > > There's no need to go through identifiers. How about this rewording? > > > > This attribute tells whether the breakpoint is visible to the user > > when set, or when the @samp{info breakpoints} command is run. > > > > Works for me. Then the documentation patch is okay with these changes. Thanks.