From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20583 invoked by alias); 22 Dec 2011 17:31:30 -0000 Received: (qmail 20570 invoked by uid 22791); 22 Dec 2011 17:31:28 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Dec 2011 17:31:12 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LWM00E008M4DZ00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Thu, 22 Dec 2011 19:31:10 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.233.41]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LWM00EQR8NXBG50@a-mtaout21.012.net.il>; Thu, 22 Dec 2011 19:31:10 +0200 (IST) Date: Thu, 22 Dec 2011 17:59:00 -0000 From: Eli Zaretskii Subject: Re: [RFA/commit] Improve gdb_realpath for Windows hosts In-reply-to: <1324574084-7971-1-git-send-email-brobecker@adacore.com> To: Joel Brobecker Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <837h1ozf6p.fsf@gnu.org> References: <1324574084-7971-1-git-send-email-brobecker@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00787.txt.bz2 > From: Joel Brobecker > Cc: Joel Brobecker > Date: Thu, 22 Dec 2011 21:14:44 +0400 > > gdb/ChangeLog: > > * utils.c (gdb_realpath): Add better support for Windows hosts. > > Tested on x86-windows. Any objection to this? Looks good to me. Although there's a subtle semantic difference between `realpath' on Posix platforms and GetFullPathName: the former requires the file to exist, while the latter does not. But I reckon we handle this somewhere... Did you test this with UNC file names?