Re: [patch 2/2] New 'explore' command Python implementation (with docs)

Doug Evans
2012-04-10T17:16:47Z

Hi.
Thanks for persevering!

LGTM

I think all the doc issues are resolved, right Eli?

On Mon, Apr 9, 2012 at 11:37 AM, Siva Chandra <sivachandra@google.com> wrote:
> <ping>
>
> Is there sufficient interest in this?
>
> On Mon, Apr 2, 2012 at 11:28 AM, Siva Chandra <sivachandra@google.com> wrote:
>> Thanks Eli, I have fixed it. The complete patch is attached.
>>
>> Code ChangeLog:
>>
>> 2012-04-02  Siva Chandra Reddy  <sivachandra@google.com>
>>
>>        New command 'explore' which helps explore values and types in
>>        scope.
>>        * NEWS: Add an entry about the new 'explore' command.
>>        * data-directory/Makefile.in: Add gdb/command/explore.py
>>        * python/lib/gdb/command/explore.py: Implemention of the 'explore'
>>        command using the GDB Python API.
>>
>> Docs ChangeLog:
>>
>> 2012-04-02  Siva Chandra Reddy  <sivachandra@google.com>
>>
>>        * gdb.texinfo (Examining Data): Document the 'explore' command.
>>
>> Testsuite ChangeLog:
>>
>> 2012-04-02  Siva Chandra Reddy  <sivachandra@google.com>
>>
>>        * gdb.python/Makefile.in: Add py-explore to EXECUTABLES.
>>        * gdb.python/py-explore.c: C program used for testing the new
>>        'explore' command on C constructs.
>>        * gdb.python/py-explore.cc: C++ program used for testing the new
>>        'explore' command on C++ constructs.
>>        * gdb-python/py-explore.exp: Tests for the new 'explore'
>>        command on C constructs.
>>        * gdb-python/py-explore-cc.exp: Tests for the new 'explore'
>>        command on C++ constructs.
>>
>> Thanks,
>> Siva Chandra