Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Document board settting
Date: Wed, 25 Apr 2012 10:47:00 -0000	[thread overview]
Message-ID: <837gx4f7o8.fsf@gnu.org> (raw)
In-Reply-To: <4F97BDD7.3080106@codesourcery.com>

> Date: Wed, 25 Apr 2012 17:03:19 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: <gdb-patches@sourceware.org>
> 
> +@section Board settings
> +In @value{GDBN} testsuite, the tests can be configured or customized in the board
> +file by means of @dfn{Board Settings}.  Here are the supported board settings:
> +
> +If the feature which is about the board setting variable is required in test
> +cases, the corresponding board setting variable should be checked in test cases.

This should be before the sentence saying "Here are the supported
board settings".  Like this:

  In @value{GDBN} testsuite, the tests can be configured or customized
  in the board file by means of @dfn{Board Settings}.  Each setting
  should be consulted by test cases that depend on the corresponding
  feature.

  Here are the supported board settings:

    The
> +location can be either the full file name of GDBserver, or the path relative to
> +testsuite directory in build dir.

 Suggest a slight rewording:

  The location is a file name of GDBserver that can be either absolute or
  relative to the testsuite subdirectory of the build directory.

> +@item in_proc_agent
> +The location of in-process agent.  If in-process agent other than its default
> +location is used in test, specify the location of in-process agent in
> +this variable.  The location can be either the full file name or the path relate
> +to testsuite directory in build dir.

Same here.

OK with those changes.

Thanks.


  reply	other threads:[~2012-04-25 10:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 15:05 Yao Qi
2012-04-24 16:07 ` Yao Qi
2012-04-25  6:24 ` Eli Zaretskii
2012-04-25  9:28   ` Yao Qi
2012-04-25 10:47     ` Eli Zaretskii [this message]
2012-04-25 11:27       ` [committed] : " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837gx4f7o8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox