From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92705-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8203 invoked by alias); 12 Jul 2012 13:29:42 -0000
Received: (qmail 8192 invoked by uid 22791); 12 Jul 2012 13:29:40 -0000
X-SWARE-Spam-Status: No, hits=-4.2 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jul 2012 13:29:25 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M7100A00UQX4200@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 12 Jul 2012 16:29:23 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M71009HNUSZOM60@a-mtaout20.012.net.il>; Thu, 12 Jul 2012 16:29:23 +0300 (IDT)
Date: Thu, 12 Jul 2012 13:29:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] MI telnet service
In-reply-to: <EB3B29AD43CA924DA27099BC8519237629DF36@EU-MBX-03.mgc.mentorg.com>
To: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <837gu9az0t.fsf@gnu.org>
References: <EB3B29AD43CA924DA27099BC8519237629DF36@EU-MBX-03.mgc.mentorg.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00161.txt.bz2

> From: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
> Date: Thu, 12 Jul 2012 11:20:36 +0000
> 
> This patch provides implementation of telnet service. This is based on initial work by Grigory Tolstolytkin.(http://sourceware.org/ml/gdb-patches/2011-11/msg00466.html)

Thanks.  A few comments about the documentation part:

> +Start a telnet service on the given port. After the service is started, 
                                           ^^
Two spaces between sentences, please (here and elsewhere, including in
comments to C code).

> +user can connect to the gdb via telnet and execute CLI commands in 
                           ^^^
"@value{GDBN}" instead of a literal "gdb".

> +new one. For telnet service to work, @value{GDBN}
> +should be configured with --enable-gdbmitel=yes.   

Use @option for options, like this: @samp{--enable-gdbmitel=yes}.

Btw, why does it make sense to require a configure-time option for
this feature? why not include it by default?