From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97319-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28320 invoked by alias); 23 Dec 2012 19:29:43 -0000
Received: (qmail 28309 invoked by uid 22791); 23 Dec 2012 19:29:42 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 23 Dec 2012 19:29:33 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MFI00H000QAGN00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sun, 23 Dec 2012 21:29:31 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFI00H9V0T7A340@a-mtaout20.012.net.il>; Sun, 23 Dec 2012 21:29:31 +0200 (IST)
Date: Sun, 23 Dec 2012 19:29:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if statement
In-reply-to: <001201cde13f$af3ad4b0$0db07e10$%muller@ics-cnrs.unistra.fr>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <837go8pnxn.fsf@gnu.org>
References: <001201cde13f$af3ad4b0$0db07e10$%muller@ics-cnrs.unistra.fr>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00792.txt.bz2

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Sun, 23 Dec 2012 19:59:49 +0100
> 
>   Looks almost obvious, but
> as it's the first of that kind,
> I thought I will send it as RFA nonetheless...
>   
>   Can similar changes be committed as obvious?
> They usually require some formatting changes,
> but generated behavior should not change.
> 
> 
> Pierre Muller
> as ARI maintainer
> 
> 
> 2012-12-20  Pierre Muller  <muller@sourceware.org>
> 
>         ARI fixes: Assignment within if rule.
>         * cli/cli-cmds.c (shell_escape): Do not set variable value inside
>         if statement.
>         (edit_command): Likewise.

Since when is that bad C, so much so that we would need to enforce it?