RE: [patch v9 1/5] New remove-symbol-file command.

Blanc, Nicolas
2013-06-19T12:20:43Z

Hi Luis,

A colleague of mine pointed out the gdb_indent.sh script for fixing indentation issues.
So I run the script over my code and fixed the issues that it reported, but the tool did not complain about
the indentation of "macro" loops, such as below. In addition, the indentation these of loops is inconsistent in
GDB, which is really confusing.

So are you sure that the indentation below is incorrect?

Thanks,

Nicolas

>> +{
>> + struct breakpoint *b;
>> +
>> + if (objfile == NULL)
>> + return;
>> +
>> + /* If the file is a shared library not loaded by the user then
>> + solib_unloaded was notified and disable_breakpoints_in_unloaded_shlib
>> + was called. In that case there is no need to take action again.
>> + */ if ((objfile->flags & OBJF_SHARED) && !(objfile->flags & OBJF_USERLOADED))
>> + return;
>> +
>> + ALL_BREAKPOINTS (b)
>> + {
>
> Identation is odd here. Should be further in.

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052