Re: [patch v9 1/5] New remove-symbol-file command.

Luis Machado
2013-06-19T12:23:38Z

On 06/19/2013 09:18 AM, Blanc, Nicolas wrote:
> Hi Luis,
>
> A colleague of mine pointed out the gdb_indent.sh script for fixing indentation issues.
> So I run the script over my code and fixed the issues that it reported, but the tool did not complain about
> the indentation of "macro" loops, such as below. In addition, the indentation these of loops is inconsistent in
> GDB, which is really confusing.
>
> So are you sure that the indentation below is incorrect?

Their use is indeed inconsistent throughout GDB. I always go with
further identation. But i don't have a strong opinion here.

Not a blocker from a patch reviewing perspective on my part.

Thanks,
Luis