From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9497 invoked by alias); 2 Mar 2014 20:47:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9478 invoked by uid 89); 2 Mar 2014 20:46:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout24.012.net.il Received: from mtaout24.012.net.il (HELO mtaout24.012.net.il) (80.179.55.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 02 Mar 2014 20:46:56 +0000 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0N1T00H00SZER500@mtaout24.012.net.il> for gdb-patches@sourceware.org; Sun, 02 Mar 2014 22:45:13 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N1T00KAMTND3100@mtaout24.012.net.il>; Sun, 02 Mar 2014 22:45:13 +0200 (IST) Date: Sun, 02 Mar 2014 20:47:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v4 0/8] Validate binary before use In-reply-to: <20140302195248.10290.22958.stgit@host1.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org, ARistovski@qnx.com Reply-to: Eli Zaretskii Message-id: <837g8ctjkj.fsf@gnu.org> References: <20140302195248.10290.22958.stgit@host1.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00021.txt.bz2 > From: Jan Kratochvil > Cc: Aleksandar Ristovski > Date: Sun, 02 Mar 2014 20:52:48 +0100 > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -43,6 +43,12 @@ maint ada show ignore-descriptive-types > the user manual for more details on descriptive types and the intended > usage of this option. > > +set solib-build-id-force (on|off) > +show solib-build-id-force > + Inferior shared library and symbol file may contain unique build-id. > + If both build-ids are present but they do not match then this setting > + enables (on) or disables (off) loading of such symbol file. > + > * New features in the GDB remote stub, GDBserver > > ** New option --debug-format=option1[,option2,...] allows one to add > @@ -51,6 +57,10 @@ maint ada show ignore-descriptive-types > Timestamps can also be turned on with the > "monitor set debug-format timestamps" command from GDB. > > + ** library-list-svr4 contains also optional attribute 'build-id' for > + each library. GDB does not load library with build-id that > + does not match such attribute. > + This part is OK. > +@table @code > +@kindex set solib-build-id-force > +@item set solib-build-id-force @var{mode} > +Setting to override @value{GDBN} build-id check. There should be a @cindex entry here about overriding the build-id check. > +Inferior shared library and symbol file may contain unique build-id. I guess you meant "libraries" and "symbol files", in plural here. > +If both build-ids are present but they do not match then this setting That "both" part came as a surprise to me. Are there only two of them? If so, where is each one stored? I don't think preceding text describes this. > +Loading non-matching symbol file may confuse debugging including breakage > +of backtrace output. > + > +By default @value{GDBN} will ignore symbol files with non-matching build-id > +while printing: Perhaps this stuff should be before you describe the option itself, because it explains why there's a need for the option in the first place. Thanks.