Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Colascione <dancol@dancol.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] display names of remote threads
Date: Fri, 15 May 2015 07:27:00 -0000	[thread overview]
Message-ID: <837fsai9lv.fsf@gnu.org> (raw)
In-Reply-To: <555520F6.7080400@dancol.org>

> Date: Thu, 14 May 2015 15:25:58 -0700
> From: Daniel Colascione <dancol@dancol.org>
> 
> commit 9b8ccc79e8a522b20ac6413751fa488622131839
> Author: Daniel Colascione <dancol@dancol.org>
> Date:   Thu May 14 15:24:08 2015 -0700
> 
>     Display names of remote threads

Please also include changes to corresponding ChangeLog files.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 4b76ce9..341ed82 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -39111,17 +39111,19 @@ the following structure:
>  @smallexample
>  <?xml version="1.0"?>
>  <threads>
> -    <thread id="id" core="0">
> +    <thread id="id" core="0" name="name">
>      ... description ...
>      </thread>
>  </threads>
>  @end smallexample
> 
>  Each @samp{thread} element must have the @samp{id} attribute that
> -identifies the thread (@pxref{thread-id syntax}).  The
> -@samp{core} attribute, if present, specifies which processor core
> -the thread was last executing on.  The content of the of @samp{thread}
> -element is interpreted as human-readable auxilliary information.
> +identifies the thread (@pxref{thread-id syntax}).  The @samp{core}
> +attribute, if present, specifies which processor core the thread was
> +last executing on.  The @samp{name} attribute, if present, specifies
> +the human-readable name of the thread.  The content of the of
> +@samp{thread} element is interpreted as human-readable
> +auxilliary information.

Something is wrong with the last sentence.  (I actually wonder why
that sentence is needed: it's not clear to me what does it want to
convey.)

The documentation part is OK with this fixed.


  reply	other threads:[~2015-05-15  7:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 22:26 Daniel Colascione
2015-05-15  7:27 ` Eli Zaretskii [this message]
2015-05-19 11:42 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837fsai9lv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dancol@dancol.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox