From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63582 invoked by alias); 23 Jun 2015 15:28:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63571 invoked by uid 89); 23 Jun 2015 15:28:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_05,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout28.012.net.il Received: from mtaout28.012.net.il (HELO mtaout28.012.net.il) (80.179.55.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Jun 2015 15:28:21 +0000 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NQE00F00LMLTX00@mtaout28.012.net.il> for gdb-patches@sourceware.org; Tue, 23 Jun 2015 18:27:59 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQE0092ZLMNM460@mtaout28.012.net.il>; Tue, 23 Jun 2015 18:27:59 +0300 (IDT) Date: Tue, 23 Jun 2015 15:28:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 5/5] btrace: maintenance commands In-reply-to: <1435047418-21611-6-git-send-email-markus.t.metzger@intel.com> To: Markus Metzger Cc: palves@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <837fquh2bd.fsf@gnu.org> References: <1435047418-21611-1-git-send-email-markus.t.metzger@intel.com> <1435047418-21611-6-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00470.txt.bz2 > From: Markus Metzger > Cc: gdb-patches@sourceware.org, Eli Zaretskii > Date: Tue, 23 Jun 2015 10:16:58 +0200 > > Add maintenance commands that help debugging the btrace record target. Thanks. > + add_setshow_boolean_cmd ("skip-pad", class_maintenance, > + &maint_btrace_pt_skip_pad, _("\ > +Set whether PAD packets should be skipped in the btrace packet history."), _("\ > +Show whether PAD packets should be skipped in the btrace packet history."),_("\ > +When enabled, PAD packets are ignored when processing the trace to compute \ > +the btrace packet history.\n\ This line is too long to fit on a standard text terminal. Is that necessary? > +This does not modify the already computed packet history. Use 'maintenance \ > +btrace clear-packet-history' to clear and recompute the existing history."), Same here (and in a few more places). > + _("Prints the raw branch tracing data.\n\ I think we use "Print", not "Prints". (Again, there are other doc strings in the patch with the same issue.) > +execution history for the @samp{record btrace} command. The > +information printed as well as the format depends on the btrace > +recording format. "Both the information and the format in which it is printed depend on ..." > +@table @code > +@item bts > +For the BTS recording format, it prints a list of blocks of sequential "print" instead of "it prints" -- this matches the style of the previous sentences. > +code. For each block, the following information is printed: > + > +@table @code @code is inappropriate here, I suggest to use @asis instead. > +@item The block number I'd lose the "The" part, it's redundant in a table. The documentation parts are OK with those fixed.