From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63802 invoked by alias); 24 Jul 2015 19:53:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63789 invoked by uid 89); 24 Jul 2015 19:53:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_JMF_BL,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout28.012.net.il Received: from mtaout28.012.net.il (HELO mtaout28.012.net.il) (80.179.55.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jul 2015 19:53:21 +0000 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NS000100C4OZE00@mtaout28.012.net.il> for gdb-patches@sourceware.org; Fri, 24 Jul 2015 22:53:29 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NS000ODKCL4I850@mtaout28.012.net.il>; Fri, 24 Jul 2015 22:53:29 +0300 (IDT) Date: Fri, 24 Jul 2015 19:53:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Make sure GDB uses a valid shell when starting the inferior and to perform the "shell" command In-reply-to: <87fv4d5p8l.fsf@redhat.com> To: Sergio Durigan Junior Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <837fpp2uz5.fsf@gnu.org> References: <1437761993-18758-1-git-send-email-sergiodj@redhat.com> <55B2850D.6030306@ericsson.com> <87k2tp5q3g.fsf@redhat.com> <838ua52wmp.fsf@gnu.org> <87fv4d5p8l.fsf@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00722.txt.bz2 > From: Sergio Durigan Junior > Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org > Date: Fri, 24 Jul 2015 15:28:58 -0400 > > Another good thing about doing this type of check is that every known > and unknown shell will still work. When we explicitly check for certain > shell's as you suggest, it means that if we forget any of them its users > will be negatively impacted. I don't think there are so many shells out there that we run a real risk of forgetting them. And even if we do, there's plenty of time till the next release to hear from those who might be negatively impacted.