Re: [PATCH v2 5/5] Add support for Intel PKRU register to GDB and GDBserver.

Sturm, Michael
2016-12-19T09:17:44Z

Hello,

thanks for the feedback, I'll go and change this. How about the rest of
the series - is it good to commit?

Thanks and Regards,
Michael

On 09/12/2016 18:15, Pedro Alves wrote:
> On 12/02/2016 01:59 AM, Luis Machado wrote:
>
>>> +set comp_flags "-I${srcdir}/../nat/"
>>> +
>>> +if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
>>> + [list debug additional_flags=${comp_flags}]] } {
>> Add 'untested "failed to compile"'
> Nope, that's already handled by prepare_for_testing itself.
> The test message used is the first argument to prepare_for_testing
> above. Unfortunately, many tests blindly pass "${testfile}.exp"...
>
> From build_executable_from_specs (called by prepare_for_testing):
>
> [....]
> # TESTNAME is the name of the test; this is passed to 'untested' if
> # something fails.
> [....]
>
> I had started using:
>
> prepare_for_testing "failed to prepare" ....
>
> a while ago. See:
>
> grep "prepare_for_testing \"[A-Za-z0-9_ ]\+" -rn
>
> Thanks,
> Pedro Alves
>

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928