Re: [PATCH v2 1/5] Sync up x86-gcc-cpuid.h with cpuid.h from gcc-6 branch.

Sturm, Michael
2016-12-05T13:42:35Z

On 02/12/2016 02:17, Luis Machado wrote:
> On 12/01/2016 07:38 AM, Michael Sturm wrote:
>> Pedro suggested a separate patch synching with GCCs cpuid.h
>> instead of just adding new bits for PKU feature.
>>
>> gdb/Changelog:
>> 2016-11-14 Michael Sturm <michael.sturm@intel.com>
>>
>> * nat/x86-gcc-cpuid.h: Replace with copy of cpuid.h
>> from gcc-6 branch.
>>
>> Change-Id: I7fadd372db689907475779c12400d123d40a71ce
>> Signed-off-by: Michael Sturm <michael.sturm@intel.com>
>> ---
>> gdb/nat/x86-gcc-cpuid.h | 128
>> ++++++++++++++++++------------------------------
>> 1 file changed, 48 insertions(+), 80 deletions(-)
>>
>> diff --git a/gdb/nat/x86-gcc-cpuid.h b/gdb/nat/x86-gcc-cpuid.h
>> index 1045521..5d81b23 100644
>> --- a/gdb/nat/x86-gcc-cpuid.h
>> +++ b/gdb/nat/x86-gcc-cpuid.h
>> @@ -1,29 +1,7 @@
>> /*
>> - * Helper cpuid.h file copied from gcc-4.8.0. Code in gdb should not
>> + * Helper cpuid.h file copied from gcc-6. Code in gdb should not
>> * include this directly, but pull in x86-cpuid.h and use that func.
>> */
>> -/*
>> - * Copyright (C) 2007-2016 Free Software Foundation, Inc.
>> - *
>> - * This file is free software; you can redistribute it and/or modify it
>> - * under the terms of the GNU General Public License as published by
>> the
>> - * Free Software Foundation; either version 3, or (at your option) any
>> - * later version.
>> - *
>> - * This file is distributed in the hope that it will be useful, but
>> - * WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> - * General Public License for more details.
>> - *
>> - * Under Section 7 of GPL version 3, you are granted additional
>> - * permissions described in the GCC Runtime Library Exception, version
>> - * 3.1, as published by the Free Software Foundation.
>> - *
>> - * You should have received a copy of the GNU General Public License
>> and
>> - * a copy of the GCC Runtime Library Exception along with this program;
>> - * see the files COPYING3 and COPYING.RUNTIME respectively. If not,
>> see
>> - * <http://www.gnu.org/licenses/>.
>> - */
>
> Is this a simple replacement of files? The copyright blurb is gone for
> some reason. I suppose that's not expected?
> Hello Luis, it's a copy of the GCC cpuid.h contents to this file. The
> copyright notice was lost by accident, I'll fix this in the next revision.
Thanks and Regards,
Michael

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928