From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32162 invoked by alias); 14 Feb 2017 15:50:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32144 invoked by uid 89); 14 Feb 2017 15:50:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:francoi, anton.kolesov@synopsys.com, arctdepc, antonkolesovsynopsyscom X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Feb 2017 15:50:22 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdfMx-0005kq-SC for gdb-patches@sourceware.org; Tue, 14 Feb 2017 10:50:21 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdfMr-0005i1-Sj; Tue, 14 Feb 2017 10:50:13 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3077 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cdfMq-0003tB-Aa; Tue, 14 Feb 2017 10:50:13 -0500 Date: Tue, 14 Feb 2017 15:50:00 -0000 Message-Id: <837f4s22m0.fsf@gnu.org> From: Eli Zaretskii To: Anton Kolesov CC: gdb-patches@sourceware.org, Francois.Bedard@synopsys.com In-reply-to: <20170214100130.29194-4-Anton.Kolesov@synopsys.com> (message from Anton Kolesov on Tue, 14 Feb 2017 13:01:29 +0300) Subject: Re: [PATCH 4/5] arc: Add disassembler helper Reply-to: Eli Zaretskii References: <20170214100130.29194-1-Anton.Kolesov@synopsys.com> <20170214100130.29194-4-Anton.Kolesov@synopsys.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00386.txt.bz2 > From: Anton Kolesov > Cc: Anton Kolesov , Francois Bedard > Date: Tue, 14 Feb 2017 13:01:29 +0300 > > Add disassembler helper for GDB, that uses opcodes structure arc_instruction > and adds convenience functions to handle instruction operands. This interface > solves at least those problems with arc_instruction: > > * Some instructions, like "push_s", have implicit operands which are not > directly present in arc_instruction. > * Operands of particular meaning, like branch/jump targets, have various > locations and meaning depending on type of branch/target. > * Access to operand value is abstracted into a separate function, so callee > code shouldn't bother if operand value is an immediate value or in a > register. > > Testcases included in this commit are fairly limited - they test exclusively > branch instructions, something that will be used in software single stepping. > Most of the other parts of this disassembler helper are tested during prologue > analysis testing. > > gdb/ChangeLog: > > yyyy-mm-dd Anton Kolesov > > * configure.tgt: Add arc-insn.o. > * arc-tdep.c (arc_delayed_print_insn): Make non-static. > (dump_arc_instruction_command): New function. > * arc-tdep.h (arc_delayed_print_insn): Add function declaration. > * arch/arc-insn.c: New file. > * arch/arc-insn.h: Likewise. > > gdb/doc/ChangeLog: > > yyyy-mm-dd Anton Kolesov > > * gdb.texinfo (Synopsys ARC): Add "maint print arc arc-instruction". > > gdb/testsuite/ChangeLog: > > yyyy-mm-dd Anton Kolesov > > * gdb.arch/arc-decode-insn.S: New file. > * gdb.arch/arc-decode-insn.exp: Likewise. OK for the documentation part. Thanks.