From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69212 invoked by alias); 12 Jun 2017 14:48:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69147 invoked by uid 89); 12 Jun 2017 14:48:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Jun 2017 14:48:46 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKQdx-000752-8Y for gdb-patches@sourceware.org; Mon, 12 Jun 2017 10:48:42 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKQdx-00072Z-5i; Mon, 12 Jun 2017 10:48:37 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3353 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKQdn-0007P7-NV; Mon, 12 Jun 2017 10:48:28 -0400 Date: Mon, 12 Jun 2017 14:48:00 -0000 Message-Id: <837f0h5kjz.fsf@gnu.org> From: Eli Zaretskii To: Yao Qi CC: gdb-patches@sourceware.org In-reply-to: <1497256916-4958-7-git-send-email-yao.qi@linaro.org> (message from Yao Qi on Mon, 12 Jun 2017 09:41:37 +0100) Subject: Re: [PATCH 06/25] Generate c for feature instead of tdesc Reply-to: Eli Zaretskii References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-7-git-send-email-yao.qi@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00317.txt.bz2 > From: Yao Qi > Date: Mon, 12 Jun 2017 09:41:37 +0100 > > gdb/doc: > > 2017-06-08 Yao Qi > > * gdb.texinfo (Maintenance Commands): Document optional > argument of "maint print c-tdesc". Thanks. > -@kindex maint print c-tdesc > +@kindex maint print c-tdesc @r{[}@var{file}@r{]} > @item maint print c-tdesc > -Print the current target description (@pxref{Target Descriptions}) as > -a C source file. The created source file can be used in @value{GDBN} > -when an XML parser is not available to parse the description. > +Print the target description (@pxref{Target Descriptions}) as > +a C source file. The target description is got from the optional ^^^^^^ "is produced", I guess? Or maybe I don't understand what you mean by "is got" here. > +argument @var{file} or the current target description. I think this should be described in the reverse order: By default, the target description is for the current target, but if the optional argument @var{file} is provided, that file is used to produce the description. > The created > +source file can be used in @value{GDBN} when an XML parser is not > +available to parse the description. I also have some clarification requests (and I do realize that the original text had the same issues): . I think we should say a few words regarding the argument FILE: I don't believe _any_ file will do in this role, so we should tell what kind of files are expected here. . "The created source file can be used in GDB ..." -- used how? I'd prefer that we said a sentence or tow about that as well, or had a cross-reference to where that is described. Also, what about a NEWS entry?