From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27656 invoked by alias); 19 Dec 2017 16:23:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27363 invoked by uid 89); 19 Dec 2017 16:23:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*r:4.82 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Dec 2017 16:23:26 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRKfr-00080R-VI for gdb-patches@sourceware.org; Tue, 19 Dec 2017 11:23:24 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRKfm-0007yE-WF; Tue, 19 Dec 2017 11:23:19 -0500 Received: from [176.228.60.248] (port=2203 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eRKfm-0001OO-E9; Tue, 19 Dec 2017 11:23:18 -0500 Date: Tue, 19 Dec 2017 16:23:00 -0000 Message-Id: <837etiptz2.fsf@gnu.org> From: Eli Zaretskii To: Stafford Horne CC: gdb-patches@sourceware.org, openrisc@lists.librecores.org In-reply-to: <20171219142257.13402-2-shorne@gmail.com> (message from Stafford Horne on Tue, 19 Dec 2017 23:22:54 +0900) Subject: Re: [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature Reply-to: Eli Zaretskii References: <20171219142257.13402-1-shorne@gmail.com> <20171219142257.13402-2-shorne@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00430.txt.bz2 > From: Stafford Horne > Cc: Openrisc , Stafford Horne > Date: Tue, 19 Dec 2017 23:22:54 +0900 > > Until now this feature has existed but was not documented. Adding docs > and tests. Thanks! > +@item info registers @var{reggroup} @dots{} > +Print the name and value of the registers in each of the specified > +@var{reggroup}. The @var{reggoup} can be any of those returned by Please use "@var{reggroup}s", with the trailing "s", otherwise this is not correct English. > +@code{maint print reggroups}. Please add here a cross-reference to the node where "maint print reggroups" is described. > c = add_info ("registers", info_registers_command, _("\ > List of integer registers and their contents, for selected stack frame.\n\ > -Register name as argument means describe only that register.")); > +Register name as argument means describe only that register.\n\ > +Register group name as argument means describe the registers in the\n\ > +named register group.")); Since this command accepts more than one reggroup, I think the doc string should mention that. The documentation parts are okay with these nits fixed.