From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51755 invoked by alias); 29 Aug 2018 19:33:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51737 invoked by uid 89); 29 Aug 2018 19:33:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UPPERCASE_50_75 autolearn=no version=3.3.2 spammy=Hx-languages-length:970 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 19:33:08 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fv6D7-0005vo-Ri for gdb-patches@sourceware.org; Wed, 29 Aug 2018 15:33:06 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fv6D7-0005vW-JM; Wed, 29 Aug 2018 15:33:01 -0400 Received: from [176.228.60.248] (port=2771 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fv6D6-0002ZA-NS; Wed, 29 Aug 2018 15:33:01 -0400 Date: Wed, 29 Aug 2018 19:33:00 -0000 Message-Id: <837ek92cke.fsf@gnu.org> From: Eli Zaretskii To: tom@tromey.com CC: palves@redhat.com, gdb-patches@sourceware.org In-reply-to: <838t4p2crb.fsf@gnu.org> (message from Eli Zaretskii on Wed, 29 Aug 2018 22:28:40 +0300) Subject: Re: [PATCH] Fix windows-nat.c for -Wnarrowing References: <20180829174253.18507-1-tom@tromey.com> <88f0fbca-f10a-9139-f96a-7934e10a937c@redhat.com> <87in3t3sqb.fsf@tromey.com> <87efeh3snr.fsf@tromey.com> <83a7p52dbh.fsf@gnu.org> <87a7p53rm4.fsf@tromey.com> <838t4p2crb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00774.txt.bz2 > Date: Wed, 29 Aug 2018 22:28:40 +0300 > From: Eli Zaretskii > CC: tom@tromey.com, palves@redhat.com, gdb-patches@sourceware.org > > I don't understand: EXCEPTION_ACCESS_VIOLATION is defined like this: > > #define STATUS_ACCESS_VIOLATION 0xC0000005 > #define EXCEPTION_ACCESS_VIOLATION STATUS_ACCESS_VIOLATION > > And you've removed DWORD from the definition of xlate. So where does > DWORD come from? Ah, I see: it's a MinGW64 specific thing. It defines #define STATUS_ACCESS_VIOLATION (DWORD)0xC0000005 So I would suggest to do this: static const struct xlate_exception xlate[] = { {(long)EXCEPTION_ACCESS_VIOLATION, GDB_SIGNAL_SEGV}, {(long)STATUS_STACK_OVERFLOW, GDB_SIGNAL_SEGV}, {(long)EXCEPTION_BREAKPOINT, GDB_SIGNAL_TRAP}, {(long)DBG_CONTROL_C, GDB_SIGNAL_INT}, {(long)EXCEPTION_SINGLE_STEP, GDB_SIGNAL_TRAP}, {(long)STATUS_FLOAT_DIVIDE_BY_ZERO, GDB_SIGNAL_FPE}, {-1L, GDB_SIGNAL_UNKNOWN} };