From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6133 invoked by alias); 28 Dec 2018 07:09:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5856 invoked by uid 89); 28 Dec 2018 07:09:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=U*gdb-patches, 0300, gdb-patches@sourceware.org, gdbpatchessourcewareorg X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Dec 2018 07:09:12 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcmGX-0003YJ-P3 for gdb-patches@sourceware.org; Fri, 28 Dec 2018 02:09:10 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcmGX-0003Xh-1v; Fri, 28 Dec 2018 02:09:05 -0500 Received: from [176.228.60.248] (port=3985 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gcmGW-0006I5-Lm; Fri, 28 Dec 2018 02:09:05 -0500 Date: Fri, 28 Dec 2018 07:09:00 -0000 Message-Id: <837efu6sby.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: <1ebc24f4-9b09-4a42-6b24-f43f6641eb9d@polymtl.ca> (message from Simon Marchi on Mon, 24 Dec 2018 11:29:36 -0500) Subject: Re: GDB internal error in pc_in_thread_step_range References: <83h8kjr8r6.fsf@gnu.org> <100001f1b27aa7d90902a75d5db37710@polymtl.ca> <83a7m6tk92.fsf@gnu.org> <8336qxfpjo.fsf@gnu.org> <83tvjde68l.fsf@gnu.org> <83ftutcy7p.fsf@gnu.org> <659d33b5e4af35aea6c3aaef08559f31@polymtl.ca> <837eg4cick.fsf@gnu.org> <988ca92d2c5c976fbea57c2381eb6279@polymtl.ca> <834lb6ar3g.fsf@gnu.org> <83sgyo8brg.fsf@gnu.org> <83k1jy9a2k.fsf@gnu.org> <1ebc24f4-9b09-4a42-6b24-f43f6641eb9d@polymtl.ca> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00382.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Simon Marchi > Date: Mon, 24 Dec 2018 11:29:36 -0500 > > >>> --- gdb/coffread.c~1 2018-07-04 18:41:59.000000000 +0300 > >>> +++ gdb/coffread.c 2018-12-23 10:24:15.758116900 +0200 > >>> @@ -874,8 +874,10 @@ coff_symtab_read (minimal_symbol_reader > >>> int section = cs_to_section (cs, objfile); > >>> > >>> tmpaddr = cs->c_value; > >>> - record_minimal_symbol (reader, cs, tmpaddr, mst_text, > >>> - section, objfile); > >>> + /* Don't record unresolved symbols. */ > >>> + if (!(cs->c_secnum <= 0 && cs->c_value == 0)) > >>> + record_minimal_symbol (reader, cs, tmpaddr, mst_text, > >>> + section, objfile); > >>> > >>> fcn_line_ptr = main_aux.x_sym.x_fcnary.x_fcn.x_lnnoptr; > >>> fcn_start_addr = tmpaddr; > >> > >> That looks good to me. > > > > Should I push it to the master branch? > > Yes, just make sure to include the relevant info in the commit log. > It would be a good idea to link back to this thread, so someone doing > archeology can find why we added this. Done. Thanks for your help with investigating this issue and with finding the right solution for it.