From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80042 invoked by alias); 29 Mar 2019 12:32:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80025 invoked by uid 89); 29 Mar 2019 12:32:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,BODY_8BITS,GARBLED_BODY,SPF_PASS autolearn=no version=3.3.1 spammy=chinese, Chinese, HContent-type:plain, circle X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Mar 2019 12:32:10 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9qg5-0005ES-0S; Fri, 29 Mar 2019 08:32:09 -0400 Received: from [176.228.60.248] (port=1586 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h9qg2-0006bz-9S; Fri, 29 Mar 2019 08:32:08 -0400 Date: Fri, 29 Mar 2019 12:32:00 -0000 Message-Id: <837echkgjo.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?0JLQu9Cw0LTQuNC80LjRgCDQnNCw0YDRgtGM0Y/QvdC+0LI=?= CC: gdb-patches@sourceware.org In-reply-to: (message from =?utf-8?B?0JLQu9Cw0LTQuNC80LjRgCDQnNCw0YDRgtGM0Y/QvdC+0LI=?= on Fri, 29 Mar 2019 12:38:50 +0300) Subject: Re: [PATCH][PR server/24377] Fix mixing English and system default languages in error messages on Windows References: <83mullpwg6.fsf@gnu.org> <83ef6qjdbb.fsf@gnu.org> <838swyjafd.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00744.txt.bz2 > From: Владимир Мартьянов > Date: Fri, 29 Mar 2019 12:38:50 +0300 > Cc: gdb-patches@sourceware.org > > Using system default locale is not a good idea, user must have a way > to change message language. If somebody have to debug on chinese > Windows, he'll get Chinese messages. And this way mustn't affect any > other applications or the system itself. LC_ALL and other env. > variables will affect only gettext, not FormatMessage in the current > implementation. That completes the full circle and gets us right back to square one. Where you wanted to force FormatMessage to use the English language and I asked whether this isn't a step backward. Anyway, since we have reviewed the various ways of fixing this, I think you now have all the information you need to produce a patch. Telling FormatMessage to use English is simple, and letting users choose a different locale is only meaningful if the other messages, those which aren't output via FormatMessage, can also be translated to other languages, which requires to use _() and Gettext.