From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157135-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24720 invoked by alias); 27 Jun 2019 02:36:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 24711 invoked by uid 89); 27 Jun 2019 02:36:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HTo:U*tom
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jun 2019 02:36:07 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38866)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hgKGa-0005Xf-U5; Wed, 26 Jun 2019 22:36:04 -0400
Received: from [176.228.60.248] (port=4591 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hgKGa-0002sx-71; Wed, 26 Jun 2019 22:36:04 -0400
Date: Thu, 27 Jun 2019 02:36:00 -0000
Message-Id: <837e97kb5m.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
CC: cbiesinger@google.com, gdb-patches@sourceware.org
In-reply-to: <87pnn03vmp.fsf@tromey.com> (message from Tom Tromey on Wed, 26	Jun 2019 15:05:34 -0600)
Subject: Re: [PATCH] Add an Objfile.lookup_global_symbol function
References: <20190625220832.247935-1-cbiesinger@google.com>	<83pnn0jr39.fsf@gnu.org> <87pnn03vmp.fsf@tromey.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-06/txt/msg00609.txt.bz2

> From: Tom Tromey <tom@tromey.com>
> Cc: Christian Biesinger <cbiesinger@google.com>,  gdb-patches@sourceware.org
> Date: Wed, 26 Jun 2019 15:05:34 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> +@defun Objfile.lookup_global_symbol (name @r{[}, domain@r{]})
> >> +Searches for a global symbol by name in this objfile. Optionally, the
> Eli>                                                        ^^
> Eli> Two spaces between sentences (here and elsewhere in the patch),
> Eli> please.
> 
> I wonder whether the parameter names ought to be wrapped in @var{}.

It should, thanks for catching that.