From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56830 invoked by alias); 24 Nov 2016 18:41:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56821 invoked by uid 89); 24 Nov 2016 18:41:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ui_out_table, ui_out_hdr, get_next_header, sk:append_ X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Nov 2016 18:41:33 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54C71C04B325; Thu, 24 Nov 2016 18:41:32 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAOIfVGX025131; Thu, 24 Nov 2016 13:41:31 -0500 Subject: Re: [PATCH 13/22] Replace hand-made linked list of ui_out_hdr by vector and iterator To: Simon Marchi , gdb-patches@sourceware.org References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-13-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <837e3dd8-c636-48e2-be9f-79ab23026db8@redhat.com> Date: Thu, 24 Nov 2016 18:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161124152710.25007-13-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00776.txt.bz2 On 11/24/2016 03:27 PM, Simon Marchi wrote: > Instead of keeping pointers to first, last and current ui_out_hdr in > ui_out_table, we can use an std::vector and an iterator. Direct random > access of to vector helps make get_next_header a bit nicer by avoiding > iterating on all the headers. append_header_to_list is also a bit > simpler. Inserting into a vector invalidates iterators if it causes reallocation. I think we're good because there's be some call to start_body or start_row before the iterator is ever dereferenced, right? Thanks, Pedro Alves