From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-162723-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 42902 invoked by alias); 3 Jan 2020 13:20:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 42891 invoked by uid 89); 3 Jan 2020 13:20:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Jan 2020 13:20:07 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58823)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1inMs0-0000jl-5D; Fri, 03 Jan 2020 08:20:04 -0500
Received: from [176.228.60.248] (port=2235 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1inMrz-0001PF-Cr; Fri, 03 Jan 2020 08:20:03 -0500
Date: Fri, 03 Jan 2020 13:20:00 -0000
Message-Id: <837e28isn1.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
CC: gdb-patches@sourceware.org
In-reply-to: <39b8efed-e23e-db20-4b28-332ceda2d8df@dronecode.org.uk> (message	from Jon Turney on Fri, 3 Jan 2020 13:11:24 +0000)
Subject: Re: [PATCH] Fix a crash with a malformed PE header
References: <20200102125405.11499-1-jon.turney@dronecode.org.uk> <835zhuj71c.fsf@gnu.org> <39b8efed-e23e-db20-4b28-332ceda2d8df@dronecode.org.uk>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2020-01/txt/msg00037.txt.bz2

> Cc: Eli Zaretskii <eliz@gnu.org>
> From: Jon Turney <jon.turney@dronecode.org.uk>
> Date: Fri, 3 Jan 2020 13:11:24 +0000
> 
> > Thanks.  Would it make sense to produce some diagnostic output here,
> > when an appropriate debug-FOO option is set?
> 
> Yes, I suppose that's better than just a comment.
> 
> How about the attached?

LGTM, but please wait for someone else to approve this formally.

Thanks.