From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Using the vcs_to_changelog.py script
Date: Thu, 13 Feb 2020 18:58:00 -0000 [thread overview]
Message-ID: <837e0qqpps.fsf@gnu.org> (raw)
In-Reply-To: <675991ee-28c0-ce5a-6327-c6ad80ccb1c3@polymtl.ca> (message from Simon Marchi on Thu, 13 Feb 2020 11:26:11 -0500)
> Cc: binutils@sourceware.org, gdb-patches@sourceware.org
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Thu, 13 Feb 2020 11:26:11 -0500
>
> My understanding from:
>
> - past dicussions (the big one on bug-
> - the proposed change to standards.texi that you sent
>
> is that the ChangeLog entry is redundant enough with the combination of:
>
> - a good commit message that explains why the change is done
> - the diff of the change
>
> which are both kept by the VCS. And for that reason, it's fine not to keep
> a ChangeLog file in the VCS.
Yes, but:
1) the proposed change was not yet approved as part of the official
policy
2) we need some guidelines for "good commit messages", otherwise
patch review will need to pay a lot of attention to discussing
that and making sure the log messages are fine
> However, for the benefit of people just using
> tarballs, and not the VCS, we generate a ChangeLog file from the diff.
> Naturally, the generated ChangeLog will be less informative than one written
> by humans (it won't say what changed in a function, it will just say that
> the function has been modified), but since that procedure was adopted by glibc,
> and is mentioned in the proposed standards.texi change, then it must have been
> considered an acceptable compromise.
I have yet to see this accepted as GNU policy. And at least
personally, having a ChangeLog in a tarball that just says which
function was changed on what date is almost useless to me (and I do
sometimes need to work without access to the VCS repositories).
next prev parent reply other threads:[~2020-02-13 18:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 23:33 Simon Marchi
2020-02-13 1:03 ` Alan Modra
2020-02-13 2:29 ` Jeff Law
2020-02-13 3:13 ` Simon Marchi
2020-02-13 14:13 ` Eli Zaretskii
2020-02-13 3:37 ` Eli Zaretskii
2020-02-13 14:19 ` Simon Marchi
[not found] ` <83a75mqyry.fsf@gnu.org>
2020-02-13 16:26 ` Simon Marchi
2020-02-13 18:58 ` Eli Zaretskii [this message]
2020-02-13 19:09 ` Philippe Waroquiers
2020-02-13 19:29 ` Eli Zaretskii
2020-02-13 20:56 ` Simon Marchi
2020-02-13 21:07 ` Simon Marchi
2020-02-14 9:45 ` Eli Zaretskii
2020-02-14 19:31 ` Simon Marchi
2020-02-14 20:16 ` Eli Zaretskii
2020-02-14 21:08 ` Simon Marchi
2020-02-15 7:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837e0qqpps.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox