From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 9E5EA3894C00 for ; Tue, 1 Sep 2020 18:14:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9E5EA3894C00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:56496) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDAnO-0005Zt-Gt; Tue, 01 Sep 2020 14:14:14 -0400 Received: from [176.228.60.248] (port=2305 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kDAnN-0000Gu-Oz; Tue, 01 Sep 2020 14:14:14 -0400 Date: Tue, 01 Sep 2020 21:13:57 +0300 Message-Id: <837dtdweje.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves Cc: gdb-patches@sourceware.org In-Reply-To: <20200901180703.20045-1-pedro@palves.net> (message from Pedro Alves on Tue, 1 Sep 2020 19:07:03 +0100) Subject: Re: [PATCH] Add MI "-break-insert --qualified" References: <20200901180703.20045-1-pedro@palves.net> X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 18:14:16 -0000 > From: Pedro Alves > Date: Tue, 1 Sep 2020 19:07:03 +0100 > > gdb/ChangeLog: > > * mi/mi-cmd-break.c (mi_cmd_break_insert_1): Handle "--qualified". > > gdb/doc/ChangeLog: > > * gdb.texinfo (GDB/MI Breakpoint Commands): Document > "-break-insert --qualified" and "-dprintf-insert --qualified". > > gdb/testsuite/ChangeLog: > > * NEWS: Document "-break-insert --qualified". > * gdb.mi/mi-break-qualified.cc: New file. > * gdb.mi/mi-break-qualified.exp: New file. > * lib/mi-support.exp (mi_create_breakpoint_multi) > (mi_make_breakpoint_loc, mi_make_breakpoint_multi): New > procedures. > (mi_create_breakpoint_1): New, factored out from > mi_create_breakpoint. Thanks, the documentation parts are OK.