From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23716 invoked by alias); 8 Oct 2014 14:59:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23702 invoked by uid 89); 8 Oct 2014 14:59:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bl2-obe.outbound.protection.outlook.com Received: from mail-bl2on0088.outbound.protection.outlook.com (HELO na01-bl2-obe.outbound.protection.outlook.com) (65.55.169.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 08 Oct 2014 14:59:25 +0000 Received: from BY2FFO11FD060.protection.gbl (10.1.14.33) by BY2FFO11HUB034.protection.gbl (10.1.14.118) with Microsoft SMTP Server (TLS) id 15.0.1039.16; Wed, 8 Oct 2014 14:59:20 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BY2FFO11FD060.mail.protection.outlook.com (10.1.15.184) with Microsoft SMTP Server (TLS) id 15.0.1039.16 via Frontend Transport; Wed, 8 Oct 2014 14:59:20 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1XbsgJ-00077D-Up; Wed, 08 Oct 2014 07:57:35 -0700 From: Ajit Kumar Agarwal To: Pedro Alves , Joel Brobecker CC: "gdb-patches@sourceware.org" , Vinod Kathail , Vidhumouli Hunsigida , "Nagaraju Mekala" Subject: RE: [Patch] Microblaze: Port of Linux gdbserver Date: Wed, 08 Oct 2014 14:59:00 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: <837dac87732943cea0247f2a6e06097d@BY2FFO11FD060.protection.gbl> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(13464003)(51704005)(479174003)(377454003)(199003)(377424004)(164054003)(24454002)(189002)(54356999)(21056001)(50986999)(47776003)(108616004)(95666004)(80022003)(19580395003)(86362001)(19580405001)(92566001)(44976005)(104016003)(85306004)(64706001)(76482002)(20776003)(107046002)(77096002)(6806004)(87936001)(120916001)(85852003)(2656002)(50466002)(23676002)(4396001)(46102003)(99396003)(53416004)(15975445006)(74316001)(106466001)(31966008)(107986001)(24736002)(23106004);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2FFO11HUB034;H:xsj-pvapsmtpgw01;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB034; X-Forefront-PRVS: 0358535363 Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-OriginatorOrg: xilinx.com X-SW-Source: 2014-10/txt/msg00153.txt.bz2 V2l0aCB0aGUgYmVsb3cgZ2Ric2VydmVyIFBhdGNoLCBoZXJlIGFyZSB0aGUg dGVzdCByZXN1bHRzIG9mIHJ1bm5pbmcgdGhlIGdkYiByZWdyZXNzaW9uIHRl c3RzdWl0ZSAoZ2RiLmJhc2UpIC4gVGhpcyB0ZXN0cyByZXN1bHRzIHdpdGgg dGhlIGZvbGxvd2luZyBwYXRjaGVzIGFscmVhZHkgc2VudCB0byBGU0YgY29t bXVuaXR5IGZvciByZXZpZXcuDQoNCkdEQiBDbGllbnQ6DQoNCjEuIEFkZCBM aXR0bGUgRW5kaWFuIGJyZWFrcG9pbnQuDQoyLiBBZGQgU29mdHdhcmUgU2lu Z2xlIFN0ZXAuDQoNCldpdGggdGhlIGFib3ZlIEdEQiBDbGllbnQsIGJlbG93 IGdkYnNlcnZlciBwYXRjaGVzICBhcmUgdXNlZC4NCg0KDQogICAgICAgICAg ICAgICAgPT09IGdkYiBTdW1tYXJ5ID09PQ0KDQojIG9mIGV4cGVjdGVkIHBh c3NlcyAgICAgICAgICAgIDc2ODANCiMgb2YgdW5leHBlY3RlZCBmYWlsdXJl cyAgICAgICAgMjEzOA0KIyBvZiB1bmV4cGVjdGVkIHN1Y2Nlc3NlcyAgICAg ICAyDQojIG9mIGV4cGVjdGVkIGZhaWx1cmVzICAgICAgICAgIDUNCiMgb2Yg a25vd24gZmFpbHVyZXMgICAgICAgICAgICAgMjINCiMgb2YgdW5yZXNvbHZl ZCB0ZXN0Y2FzZXMgICAgICAgMjgNCiMgb2YgdW50ZXN0ZWQgdGVzdGNhc2Vz ICAgICAgICAgNDINCiMgb2YgdW5zdXBwb3J0ZWQgdGVzdHMgICAgICAgICAg MTI0DQoNClRoYW5rcyAmIFJlZ2FyZHMNCkFqaXQNCi0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQpGcm9tOiBBaml0IEt1bWFyIEFnYXJ3YWwgDQpTZW50 OiBXZWRuZXNkYXksIE9jdG9iZXIgMDgsIDIwMTQgNzoyMiBQTQ0KVG86ICdQ ZWRybyBBbHZlcyc7IE1pY2hhZWwgRWFnZXI7IEpvZWwgQnJvYmVja2VyDQpD YzogZ2RiLXBhdGNoZXNAc291cmNld2FyZS5vcmc7IFZpbm9kIEthdGhhaWw7 IFZpZGh1bW91bGkgSHVuc2lnaWRhOyBOYWdhcmFqdSBNZWthbGENClN1Ympl Y3Q6IFtQYXRjaF0gTWljcm9ibGF6ZTogUG9ydCBvZiBMaW51eCBnZGJzZXJ2 ZXINCg0KSGVsbG8gUGVkcm86DQoNClBsZWFzZSBmaW5kIHRoZSB1cGRhdGVk IHBhdGNoIHdpdGggZmVlZGJhY2sgY29tbWVudHMgaW5jb3Jwb3JhdGVkLg0K DQogICAgTWljcm9ibGF6ZTogUG9ydCBvZiBMaW51eCBnZGJzZXJ2ZXINCiAg ICANCiAgICBUaGlzIHBhdGNoIGlzIHRoZSBwb3J0IG9mIExpbnV4IGdkYnNl cnZlci4NCiAgICBUZXN0ZWQgd2l0aCBnZGIgcmVncmVzc2lvbiB0ZXN0c3Vp dGUgd2l0aCB0aGlzIHBhdGNoIG9mDQogICAgZ2Ric2VydmVyLg0KICAgIA0K ICAgIGdkYi86DQogICAgMjAxNC0xMC0wOCAgQWppdCBBZ2Fyd2FsICA8YWpp dGt1bUB4aWxpbnguY29tPg0KICAgIA0KICAgICAgICAqIGNvbmZpZ3VyZS50 Z3QgKGJ1aWxkX2dkYnNlcnZlcik6IE5ldyBEZWZpbml0aW9uLg0KICAgIA0K ICAgIGdkYi9nZGJzZXJ2ZXIvOg0KICAgIA0KICAgICAgICAqIGdkYnNlcnZl ci9NYWtlZmlsZS5pbiAobWljcm9ibGF6ZS1saW51eC5jKTogTmV3IHRhcmdl dC4NCiAgICAgICAgKiBnZGJzZXJ2ZXIvY29uZmlndXJlLnNydiAobWljcm9i bGF6ZSotKi1saW51eCopOiBOZXcgdGFyZ2V0Lg0KICAgICAgICAqIGdkYnNl cnZlci9saW51eC1taWNyb2JsYXplLWxvdy5jOiBOZXcgZmlsZS4NCiAgICAN CiAgICBTaWduZWQtb2ZmLWJ5OkFqaXQgQWdhcndhbCBhaml0a3VtQHhpbGlu eC5jb20NCg0KVGhhbmtzICYgUmVnYXJkcw0KQWppdA0KLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCkZyb206IFBlZHJvIEFsdmVzIFttYWlsdG86cGFs dmVzQHJlZGhhdC5jb21dDQpTZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIgMzAs IDIwMTQgNToxNCBQTQ0KVG86IEFqaXQgS3VtYXIgQWdhcndhbDsgTWljaGFl bCBFYWdlcjsgSm9lbCBCcm9iZWNrZXINCkNjOiBnZGItcGF0Y2hlc0Bzb3Vy Y2V3YXJlLm9yZzsgVmlub2QgS2F0aGFpbDsgVmlkaHVtb3VsaSBIdW5zaWdp ZGE7IE5hZ2FyYWp1IE1la2FsYQ0KU3ViamVjdDogUmU6IFtQYXRjaCwgbWlj cm9ibGF6ZV06IFBvcnQgb2YgTGludXggZ2Ric2VydmVyDQoNCk9uIDA5LzIz LzIwMTQgMDE6NDkgUE0sIEFqaXQgS3VtYXIgQWdhcndhbCB3cm90ZToNCg0K Pj4+PiA+Pj4gTm90ZSBub3RoaW5nIGlzIGRvbmUgd2l0aCB2YWxpZF9wLiAg SXQncyB3cml0ZS1vbmx5LiAgQ29tcGFyZSB3aXRoIG90aGVyIHBvcnRzLCBs aWtlIGFybS10ZGVwLmMgb3IgbWlwcy10ZGVwLmMuDQo+PiA+IA0KPj4gPiBX b3VsZCBsb29rIGludG8gdGhpcyBhbmQgd2lsbCBtYWtlIHRoZSBtb2RpZmlj YXRpb24uDQo+IFRoYW5rcy4NCg0KSSdkIG11Y2ggcHJlZmVyIGlmIHdlIGhh ZCB0aGF0IHBhdGNoIGluIHRoZSB0cmVlIGJlZm9yZSBhY2NlcHRpbmcgZnVy dGhlciBwYXRjaGVzIHRoYXQgdHdlYWsgdGhpbmdzIGFyb3VuZCByZWdpc3Rl ciBuYW1lcywgZXRjLiAgQ291bGQgeW91IHNlbmQgdGhhdCAoYXMgYW4gaW5k ZXBlbmRlbnQgcGF0Y2gsIGluIGEgbmV3IHRocmVhZCkuDQoNCj4gKyNkZWZp bmUgbWljcm9ibGF6ZV9udW1fcmVncwlcDQo+ICsgIChzaXplb2YgbWljcm9i bGF6ZV9yZWdtYXAgLyBzaXplb2YgbWljcm9ibGF6ZV9yZWdtYXBbMF0pDQoN CiNkZWZpbmUgbWljcm9ibGF6ZV9udW1fcmVncyBBUlJBWV9TSVpFIChtaWNy b2JsYXplX3JlZ21hcCkNCg0KPiArDQo+ICtzdGF0aWMgaW50DQo+ICttaWNy b2JsYXplX2Nhbm5vdF9zdG9yZV9yZWdpc3RlciAoaW50IHJlZ25vKSB7DQo+ ICsgIGlmIChtaWNyb2JsYXplX3JlZ21hcFtyZWdub10gPT0gLTEgfHwgcmVn bm8gPT0gMCkNCj4gKyAgICByZXR1cm4gMTsNCj4gKw0KPiArICByZXR1cm4g MDsNCj4gK30NCj4gKw0KPiArc3RhdGljIGludA0KPiArbWljcm9ibGF6ZV9j YW5ub3RfZmV0Y2hfcmVnaXN0ZXIgKGludCByZWdubykgew0KPiArICByZXR1 cm4gMDsNCj4gK30NCj4gKw0KPiArc3RhdGljIENPUkVfQUREUg0KPiArbWlj cm9ibGF6ZV9nZXRfcGMgKHN0cnVjdCByZWdjYWNoZSAqcmVnY2FjaGUpIHsN Cj4gKyAgdW5zaWduZWQgbG9uZyBwYzsNCj4gKyAgY29sbGVjdF9yZWdpc3Rl cl9ieV9uYW1lIChyZWdjYWNoZSwgInJwYyIsICZwYyk7DQoNCkVtcHR5IGxp bmUgYWZ0ZXIgZGVjbGFyYXRpb24uICBJbiBzZXZlcmFsIG1vcmUgcGxhY2Vz IGluIHRoZSBwYXRjaC4NClBsZWFzZSBmaXggdGhlbSBhbGwuDQoNCj4gKyAg cmV0dXJuIChDT1JFX0FERFIpIChwYyk7DQo+ICt9DQoNCg0KDQo+ICsgIGlm IChyZWdubyA9PSAwKQ0KPiArICAgIHsNCj4gKyAgICAgIHVuc2lnbmVkIGxv bmcgcmVnYnVmXzAgPSAwOw0KPiArICAgICAgLyogQ2xvYmJlcmluZyByMCBz byB0aGF0IGl0IGlzIGFsd2F5cyAwIGFzIGVuZm9yY2VkIGJ5IGhhcmR3YXJl LiAgKi8NCj4gKyAgICAgIHN1cHBseV9yZWdpc3RlciAocmVnY2FjaGUsIHJl Z25vLCAoY29uc3QgY2hhciopJnJlZ2J1Zl8wKTsNCg0KCXN1cHBseV9yZWdp c3Rlcl96ZXJvZWQgKHJlZ2NhY2hlLCByZWdubyk7DQoNCj4gKyAgICB9DQo+ ICsgIGVsc2UNCj4gKyAgICB7DQo+ICsgICAgICBpZiAoc2l6ZSA8IHNpemVv ZiAobG9uZykpDQo+ICsgICAgICAgIHN1cHBseV9yZWdpc3RlciAocmVnY2Fj aGUsIHJlZ25vLCBidWYgKyBzaXplb2YgKGxvbmcpIC0gc2l6ZSk7DQo+ICsg ICAgICBlbHNlDQo+ICsgICAgICAgIHN1cHBseV9yZWdpc3RlciAocmVnY2Fj aGUsIHJlZ25vLCBidWYpOw0KPiArICAgIH0NCj4gK30NCj4gKw0KPiArLyog UHJvdmlkZSBvbmx5IGEgZmlsbCBmdW5jdGlvbiBmb3IgdGhlIGdlbmVyYWwg cmVnaXN0ZXIgc2V0LiAgcHNfbGdldHJlZ3MNCj4gKyAgIHdpbGwgdXNlIHRo aXMgZm9yIE5QVEwgc3VwcG9ydC4gICovDQo+ICsNCj4gK3N0YXRpYyB2b2lk IG1pY3JvYmxhemVfZmlsbF9ncmVnc2V0IChzdHJ1Y3QgcmVnY2FjaGUgKnJl Z2NhY2hlLCB2b2lkDQo+ICsqYnVmKQ0KDQpMaW5lIGJyZWFrIGFmdGVyICJz dGF0aWMgdm9pZCIuICBGdW5jdGlvbiBuYW1lIGdvZXMgb24gY29sdW1uIDA6 DQoNCnN0YXRpYyB2b2lkDQptaWNyb2JsYXplX2ZpbGxfZ3JlZ3NldCAoc3Ry dWN0IHJlZ2NhY2hlICpyZWdjYWNoZSwgdm9pZCAqYnVmKQ0KDQpQbGVhc2Ug bWFrZSBzdXJlIHRoYXQncyBjb3JyZWN0IHRocm91Z2hvdXQuDQoNCg0KPiAr ew0KPiArICBpbnQgaTsNCj4gKw0KPiArICBmb3IgKGkgPSAwOyBpIDwgbWlj cm9ibGF6ZV9udW1fcmVnczsgaSsrKQ0KPiArICAgIG1pY3JvYmxhemVfY29s bGVjdF9wdHJhY2VfcmVnaXN0ZXIgKHJlZ2NhY2hlLCBpLA0KPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjaGFyICopIGJ1 ZiArIA0KPiArbWljcm9ibGF6ZV9yZWdtYXBbaV0pOyB9DQo+ICsNCj4gK3N0 YXRpYyB2b2lkDQo+ICttaWNyb2JsYXplX3N0b3JlX2dyZWdzZXQgKHN0cnVj dCByZWdjYWNoZSAqcmVnY2FjaGUsIGNvbnN0IHZvaWQgKmJ1ZikgDQo+ICt7 DQo+ICsgIGludCBpOw0KPiArICBmb3IgKGkgPSAwOyBpIDwgbWljcm9ibGF6 ZV9udW1fcmVnczsgaSsrKQ0KPiArICAgIHN1cHBseV9yZWdpc3RlciAocmVn Y2FjaGUsIGksIChjaGFyICopIGJ1ZiArIA0KPiArbWljcm9ibGF6ZV9yZWdt YXBbaV0pOyB9DQo+ICsNCj4gKyNlbmRpZiAvKiBIQVZFX1BUUkFDRV9HRVRS RUdTICovDQo+ICsNCj4gK3N0YXRpYyBzdHJ1Y3QgcmVnc2V0X2luZm8gbWlj cm9ibGF6ZV9yZWdzZXRzW10gPSB7ICNpZmRlZiANCj4gK0hBVkVfUFRSQUNF X0dFVFJFR1MNCg0KV2hhdCdzIHRoZSAjaWZkZWYgZm9yPw0KDQpEaWQgdGhp cyBrZXJuZWwgcG9ydCBtYWtlIGl0IHVwc3RyZWFtIHdpdGhvdXQgUFRSQUNF X0dFVFJFR1NFVD8NCklmIHRoZXJlJ3Mgc3VwcG9ydCBmb3IgdGhhdCwgY2Fu IHlvdSBwbGVhc2Ugc3dpdGNoIHRvIHVzaW5nIGl0Pw0KDQpQVFJBQ0VfR0VU UkVHUyBpcyBzdXBwb3NlZCB0byBhbiBvbGQgd2F5IG9mIGRvaW5nIHRoaW5n cy4uLg0KDQo+ICsgIHsgUFRSQUNFX0dFVFJFR1MsIFBUUkFDRV9TRVRSRUdT LCAwLCAzNiAqIHNpemVvZiAoZWxmX2dyZWdzZXRfdCksDQo+ICsgICAgR0VO RVJBTF9SRUdTLCBtaWNyb2JsYXplX2ZpbGxfZ3JlZ3NldCwgbWljcm9ibGF6 ZV9zdG9yZV9ncmVnc2V0IA0KPiArfSwNCj4gKyAgeyAwLCAwLCAwLCAtMSwg LTEsIE5VTEwsIE5VTEwgfSwNCj4gKyNlbmRpZiAvKiBIQVZFX1BUUkFDRV9H RVRSRUdTICovDQoNCg0KPiArICB7IDAsIDAsIDAsIC0xLCAtMSwgTlVMTCwg TlVMTCB9DQo+ICt9Ow0KPiArDQoNCg0KDQo+IGRpZmYgLS1naXQgYS9nZGIv cmVnZm9ybWF0cy9taWNyb2JsYXplLXdpdGgtc3RhY2stcHJvdGVjdC5kYXQN Cj4gYi9nZGIvcmVnZm9ybWF0cy9taWNyb2JsYXplLXdpdGgtc3RhY2stcHJv dGVjdC5kYXQNCj4gaW5kZXggZjcxYzExMS4uZTM0OWI0YSAxMDA2NDQNCj4g LS0tIGEvZ2RiL3JlZ2Zvcm1hdHMvbWljcm9ibGF6ZS13aXRoLXN0YWNrLXBy b3RlY3QuZGF0DQo+ICsrKyBiL2dkYi9yZWdmb3JtYXRzL21pY3JvYmxhemUt d2l0aC1zdGFjay1wcm90ZWN0LmRhdA0KPiBAQCAtMSw3ICsxLDcgQEANCj4g ICMgRE8gTk9UIEVESVQ6IGdlbmVyYXRlZCBmcm9tIG1pY3JvYmxhemUtd2l0 aC1zdGFjay1wcm90ZWN0LnhtbA0KICAgICBeXl5eXl5eXl5eXg0KICAgICBe Xl5eXl5eXl5eXg0KICAgICBeXl5eXl5eXl5eXg0KICAgICBeXl5eXl5eXl5e Xg0KICAgICBeXl5eXl5eXl5eXg0KDQpQbGVhc2Ugc2VuZCBhIHByZXBhcmF0 b3J5LCBpbmRlcGVuZGVudCwgcGF0Y2ggdGhhdCB1cGRhdGVzIGZlYXR1cmVz L01ha2VmaWxlIGluc3RlYWQgYW5kIGdlbmVyYXRlcyB0aGlzIGZpbGUsIGlu IGEgbmV3IHRocmVhZCwgd2l0aCBzZWxmLWNvbnRhaW5lZCBkZXNjcmlwdGlv biwgZm9sbG93aW5nIHRoZQ0KY2hlY2tsaXN0Og0KIGh0dHBzOi8vc291cmNl d2FyZS5vcmcvZ2RiL3dpa2kvQ29udHJpYnV0aW9uQ2hlY2tsaXN0DQoNCj4g IG5hbWU6bWljcm9ibGF6ZV93aXRoX3N0YWNrX3Byb3RlY3QNCj4gIHhtbHRh cmdldDptaWNyb2JsYXplLXdpdGgtc3RhY2stcHJvdGVjdC54bWwNCj4gLWV4 cGVkaXRlOnIxLHBjDQo+ICtleHBlZGl0ZTpyMSxycGMNCj4gIDMyOnIwDQo+ ICAzMjpyMQ0KPiAgMzI6cjINCj4gLS0gMS43LjENCj4gDQoNCg0KVGhhbmtz LA0KUGVkcm8gQWx2ZXMNCg== >From gdb-patches-return-116478-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Oct 08 15:21:18 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 3995 invoked by alias); 8 Oct 2014 15:21:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3983 invoked by uid 89); 8 Oct 2014 15:21:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f179.google.com Received: from mail-vc0-f179.google.com (HELO mail-vc0-f179.google.com) (209.85.220.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 08 Oct 2014 15:21:16 +0000 Received: by mail-vc0-f179.google.com with SMTP id im17so7021301vcb.10 for ; Wed, 08 Oct 2014 08:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=S2M+g25qCawvywYyHAelUfMoRE1BSkr31CbTCgbmCEU=; b=GQF1KL5inIjDVKlOJcdM9LvP3/DbXTtUGXJhYve28aYIu+AUr9cMUSbwyWWlrzF7LP 88NxPcEPQIQwgvV7jt66bzpDyFI663gobQVsbMFJY6r7oEac8qQPHZYohGvqPkrhZpNN nevXD96fKzgh6mrevtTkf+A5XGRUCM87jT5AWXK266/fmlloKZ8J48E2581qf/kMHLIH oN81we4g6SqTJAHOHebkLCTBKlHkM53hUXRcTDBog+6tyPKsdrW+oX7iqMwC/Qg2fBYL L30Jcmi9dUAquGN3lE1rS3wMW95GW4pcsk66KiLJWCXylR3jGS1/NgHr5OajFpaprgc8 1WzA== X-Gm-Message-State: ALoCoQkGtgHdUF/6s9FLQq6Cn+L87wn3/mrdF6Za9RpycnnPu66MZxg28sBuhW9KNNGqdfWEIkg1 MIME-Version: 1.0 X-Received: by 10.52.115.225 with SMTP id jr1mr9387662vdb.27.1412781673879; Wed, 08 Oct 2014 08:21:13 -0700 (PDT) Received: by 10.52.181.65 with HTTP; Wed, 8 Oct 2014 08:21:13 -0700 (PDT) In-Reply-To: <87r3zd2hr3.fsf@codesourcery.com> References: <1409706936-11220-1-git-send-email-yao@codesourcery.com> <87k356lfa8.fsf@codesourcery.com> <87r3zd2hr3.fsf@codesourcery.com> Date: Wed, 08 Oct 2014 15:21:00 -0000 Message-ID: Subject: Re: [PATCH] Fix gdb.dwarf2/dwz.exp for thumb mode From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00154.txt.bz2 Content-length: 3981 On Mon, Sep 15, 2014 at 8:25 AM, Yao Qi wrote: > Yao Qi writes: > >> -if { $main_length =3D=3D "" } { >> +set main_label_offset "" >> +set test "p main_label" >> +gdb_test_multiple $test $test { >> + -re ".* =3D {.*} $hex .*\r\n$gdb_prompt $" { >> + set main_label_offset $expect_out(1,string) >> + } >> +} > > Here is the V3 of this patch, to address Andreas's comments about > getting the offset of main_label to main. > > -- > Yao (=E9=BD=90=E5=B0=A7) > From: Yao Qi > Date: Sat, 13 Sep 2014 14:51:04 +0800 > Subject: [PATCH] Fix gdb.dwarf2/dwz.exp for thumb mode > > We see the fail in gdb.dwarf2/dwz.exp in thumb mode, > > p the_int^M > $2 =3D 99^M > (gdb) FAIL: gdb.dwarf2/dwz.exp: p the_int > > In thumb mode, the lsb of references to 'main' in the assembly > (produced by dwarf assember) is set, so the generated debug > information is incorrect. > > in this patch, we add a label main_label inside function main. Linker > doesn't set its lsb in thumb mode, and we can get function main's > address by 'main_label - $main_label_offset'. This label isn't moved > out of function main in both gcc and clang. > > gdb/testsuite: > > 2014-09-15 Yao Qi > > * gdb.dwarf2/main.c (main): New lable main_label. Typo: label > * gdb.dwarf2/dwz.exp: Get the offset of main_label to main. > Return early if $main_label_offset is unknown. Get address > of main by "main_label - $main_label_offset". > > diff --git a/gdb/testsuite/gdb.dwarf2/dwz.exp b/gdb/testsuite/gdb.dwarf2/= dwz.exp > index 9175f9e..3cf4e4f 100644 > --- a/gdb/testsuite/gdb.dwarf2/dwz.exp > +++ b/gdb/testsuite/gdb.dwarf2/dwz.exp > @@ -27,8 +27,9 @@ if {[gdb_compile ${srcdir}/${subdir}/${srcfile} ${binf= ile}1.o \ > return -1 > } > > -# Start GDB and load object file, compute the function length which is > -# needed in the Dwarf Assembler below. > +# Start GDB and load object file, compute the function length and the > +# offset from main to main_label which are needed in the Dwarf Assembler > +# below. > clean_restart ${testfile}1.o > > set main_length "" > @@ -59,9 +60,17 @@ gdb_test_multiple $test $test { > } > } > > -if { $main_length =3D=3D "" } { > +set main_label_offset "" > +set test "p main_label - main" > +gdb_test_multiple $test $test { > + -re ".* =3D ($decimal)\r\n$gdb_prompt $" { > + set main_label_offset $expect_out(1,string) > + } > +} > + > +if { $main_length =3D=3D "" || $main_label_offset =3D=3D "" } { > # Bail out here, because we can't do the following tests if > - # $main_length is unknown. > + # $main_length or $main_label_offset is unknown. > return -1 > } > > @@ -71,7 +80,7 @@ gdb_exit > set asm_file [standard_output_file $srcfile2] > Dwarf::assemble $asm_file { > declare_labels partial_label int_label int_label2 > - global main_length > + global main_length main_label_offset > > extern main > > @@ -79,8 +88,8 @@ Dwarf::assemble $asm_file { > partial_label: partial_unit {} { > subprogram { > {name main} > - {low_pc main addr} > - {high_pc "main + $main_length" addr} > + {low_pc "main_label - $main_label_offset" addr} > + {high_pc "main_label - $main_label_offset + $main_length"= addr} > } > } > } > diff --git a/gdb/testsuite/gdb.dwarf2/main.c b/gdb/testsuite/gdb.dwarf2/m= ain.c > index 3ddd194..e6d4715 100644 > --- a/gdb/testsuite/gdb.dwarf2/main.c > +++ b/gdb/testsuite/gdb.dwarf2/main.c > @@ -20,5 +20,6 @@ > int > main() > { > + asm ("main_label: .globl main_label"); > return 0; > } Hi. I'd like to see comments in the code explaining why main_label exists (thumb) and why we can't put labels outside the function (clang). I shouldn't have to grind through commit logs or emails to answer these questions.