From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71390 invoked by alias); 14 Sep 2017 09:21:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71377 invoked by uid 89); 14 Sep 2017 09:21:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:eb4a X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Sep 2017 09:21:08 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A24AF81DE4; Thu, 14 Sep 2017 09:21:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A24AF81DE4 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 79BA517B6A; Thu, 14 Sep 2017 09:21:06 +0000 (UTC) Subject: Re: [PATCH] Make dwarf_expr_piece::pieces an std::vector To: Simon Marchi , gdb-patches@sourceware.org References: <1505376948-22860-1-git-send-email-simon.marchi@ericsson.com> Cc: arnez@linux.vnet.ibm.com From: Pedro Alves Message-ID: <83688181-eb4a-b2d6-f614-b011c6220cd3@redhat.com> Date: Thu, 14 Sep 2017 09:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1505376948-22860-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00371.txt.bz2 On 09/14/2017 09:15 AM, Simon Marchi wrote: > static struct piece_closure * > allocate_piece_closure (struct dwarf2_per_cu_data *per_cu, > - int n_pieces, struct dwarf_expr_piece *pieces, > + const std::vector &&pieces, const rval reference looks odd -- you can't really move the internal elements out of a const vector. I think ... > struct frame_info *frame) > { > - struct piece_closure *c = XCNEW (struct piece_closure); > + struct piece_closure *c = new piece_closure; > int i; > > c->refc = 1; > c->per_cu = per_cu; > - c->n_pieces = n_pieces; > - c->pieces = XCNEWVEC (struct dwarf_expr_piece, n_pieces); > + c->pieces = std::move (pieces); ... this isn't really moving, but actually copying, because you'll end up calling 'std::vector(const std::vector &)', not 'std::vector(std::vector &&)'. I wonder if there's ever a case for 'const T &&' parameters, and if GCC could warn about them. At least in non-template functions. Thanks, Pedro Alves