From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130608 invoked by alias); 16 Jul 2019 19:47:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130597 invoked by uid 89); 16 Jul 2019 19:47:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=proxy, popular, sk:softwar, UD:www.sourceware.org X-HELO: mail-wr1-f67.google.com Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Jul 2019 19:47:34 +0000 Received: by mail-wr1-f67.google.com with SMTP id r1so22211495wrl.7 for ; Tue, 16 Jul 2019 12:47:33 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id u186sm33896491wmu.26.2019.07.16.12.47.30 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2019 12:47:31 -0700 (PDT) Subject: Re: [RFC 2/2] Move gdb's xmalloc and friends to new file To: Alan Hayward , Tom Tromey References: <20190530213046.20542-1-tom@tromey.com> <20190530213046.20542-3-tom@tromey.com> <87a7egkszy.fsf@tromey.com> <43591E27-A08D-4138-BB6E-C09BFEA03524@arm.com> <5B7E81C9-C5FC-47AA-AFE9-61031E9C276A@arm.com> Cc: "gdb-patches@sourceware.org" , nd From: Pedro Alves Message-ID: <8367aabc-fad0-1c88-f5d5-989f97daa6ec@redhat.com> Date: Tue, 16 Jul 2019 19:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <5B7E81C9-C5FC-47AA-AFE9-61031E9C276A@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-07/txt/msg00378.txt.bz2 On 7/3/19 5:18 PM, Alan Hayward wrote: > > >> On 18 Jun 2019, at 10:30, Alan Hayward wrote: >> >> >> >>> On 17 Jun 2019, at 19:37, Pedro Alves wrote: >>> >>> On 6/17/19 6:43 PM, Tom Tromey wrote: >>>>>>>>> "Alan" == Alan Hayward writes: >>>> >>>> Alan> Looks like this breaks the building of alloc-ipa.o when using Make 3.81 >>>> Alan> I’ve tried this on a few different machines. >>>> >>>> Thanks. >>>> >>>> My first thought is that maybe we should simply declare 3.81 >>>> unsupported. It was apparently released in 2006: >>>> >>>> https://savannah.gnu.org/forum/forum.php?forum_id=4380 >>>> >>>> ... so it is quite ancient. >>>> >>>> Is there some compelling reason to keep supporting it? >>>> >>> >>> I think it depends more on what distributions ship than what >>> the release date was. E.g., if you look around the last couple >>> stable releases of popular stable distros (e.g., ubuntu, debian, fedora), >>> which GNU Make version did they ship? If the GNU Make version shipped >>> by default is not 4.x, is there an easy optional rpm/deb package >>> for GNU Make 4.x available? >>> >>> This was the same kind of investigation that led to the GCC 4.8 >>> minimum requirement. >>> >>> Also, looking around the GCC compile farm machine (including the >>> /opt/ dirs) for what is available may be a good hint/proxy for >>> determining whether bumping the requirement could cause trouble >>> for people. >> >> >> Glibc requires 4.0: >> https://www.sourceware.org/ml/libc-alpha/2018-08/msg00003.html >> Changes to build and runtime requirements: >> GNU make 4.0 or later is now required to build glibc. >> >> >> GCC still allows 3.8: >> https://gcc.gnu.org/install/prerequisites.html >> GNU make version 3.80 (or later) >> > > I’ve done a little more digging into as many machines as I could find: > > Ubuntu 16.04, 18.04 - make 4.1 > Ubuntu 14.04 - make 4.0 > Fedora 27 - make 4.2.1 > Redhat 7.5, Centos 7.5, Centos 6 - make 3.82 > Redhat 5.8, 6.9 - make 3.81 > OpenSuse 42.2 - 4.2.1 > > Also: https://software.opensuse.org/package/make confirms a mix of 4.21 and > 3.82 as the versions in various latest distros. > > I’ve tried building using make 3.82, and it works for me. > Make 3.82 was released in 2010. > > Any objection upping the minimum make version to 3.82 ? > Fine with me as well. Thanks for digging into all those machines. Thanks, Pedro Alves