From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16134 invoked by alias); 15 Apr 2009 10:06:22 -0000 Received: (qmail 16109 invoked by uid 22791); 15 Apr 2009 10:06:18 -0000 X-SWARE-Spam-Status: No, hits=2.6 required=5.0 tests=AWL,BAYES_00,BOTNET,RCVD_IN_JMF_BL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Apr 2009 10:06:10 +0000 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KI400600ZZZSP00@i-mtaout1.012.net.il> for gdb-patches@sources.redhat.com; Wed, 15 Apr 2009 13:05:21 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.34.97]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KI5001CD00WBKD0@i-mtaout1.012.net.il>; Wed, 15 Apr 2009 13:05:21 +0300 (IDT) Date: Wed, 15 Apr 2009 10:06:00 -0000 From: Eli Zaretskii Subject: Re: Configuring gdb_wchar.h In-reply-to: To: Tom Tromey Cc: gdb-patches@sources.redhat.com Reply-to: Eli Zaretskii Message-id: <8363h6mdue.fsf@gnu.org> References: <8363hboz5x.fsf@gnu.org> <833acbo32k.fsf@gnu.org> <83myajma7a.fsf@gnu.org> <83iql7m7r1.fsf@gnu.org> <83hc0rm1mh.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00298.txt.bz2 > Cc: gdb-patches@sources.redhat.com > From: Tom Tromey > Date: Tue, 14 Apr 2009 18:23:25 -0600 > > Here's an updated patch that changes charset.c to use pexecute and to > detect errors. It also adds parsing for libiconv-style "iconv -l" > output. > > I tried this with the glibc iconv, libiconv's iconv, and a phony iconv > that prints garbage and exits with an error. > > If you want to give it a try, to make sure it still builds on DJGPP, > that would be nice. If it works for you I will check it in. It builds fine, but the result seems strange to me: GDB now lists a long list of character sets in response to "set target-charset TAB". What happens is that find_charset_names correctly notices that "iconv -l" exited with a non-zero status (this is still with libiconv 1.7, where the -l switch is not supported), but then _initialize_charset falls back on using DEFAULT_CHARSET_NAMES, which seem to assume a glibc-based system. I rather expected the result to be that only a single target charset be available. Am I missing something? Should DEFAULT_CHARSET_NAMES be redefined on DJGPP to something different from what charset-list.h defines it? I will upgrade to a newer libiconv and try with that, once the result for 1.7 is as expected (whatever that might be). Thanks.