From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7203 invoked by alias); 16 Apr 2009 17:47:56 -0000 Received: (qmail 7183 invoked by uid 22791); 16 Apr 2009 17:47:54 -0000 X-SWARE-Spam-Status: No, hits=1.7 required=5.0 tests=AWL,BAYES_40,J_CHICKENPOX_13,J_CHICKENPOX_23,J_CHICKENPOX_27,J_CHICKENPOX_63,J_CHICKENPOX_92,J_CHICKENPOX_93,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout3.012.net.il (HELO mtaout3.012.net.il) (84.95.2.7) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Apr 2009 17:47:49 +0000 Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KI700I00FZJHZ00@i_mtaout3.012.net.il> for gdb-patches@sources.redhat.com; Thu, 16 Apr 2009 20:47:46 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.34.97]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KI70020FG3LXUD1@i_mtaout3.012.net.il>; Thu, 16 Apr 2009 20:47:46 +0300 (IDT) Date: Thu, 16 Apr 2009 17:47:00 -0000 From: Eli Zaretskii Subject: Re: needed-list fails in libiberty In-reply-to: To: Ian Lance Taylor Cc: joseph@codesourcery.com, gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com Reply-to: Eli Zaretskii Message-id: <8363h4lcc3.fsf@gnu.org> References: <83vdp7mile.fsf@gnu.org> <83r5zvmh5v.fsf@gnu.org> <837i1mmiyh.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00373.txt.bz2 > Cc: joseph@codesourcery.com, gcc-patches@gcc.gnu.org, > gdb-patches@sources.redhat.com > From: Ian Lance Taylor > Date: Wed, 15 Apr 2009 06:49:48 -0700 > > Eli Zaretskii writes: > > >> > 2009-04-14 Eli Zaretskii > >> > > >> > * Makefile.in (needed-list): Target removed (not used in GCC > >> > 3.0 and later). All references deleted. > >> > >> This is OK if you've done a clean bootstrap on a primary platform. I bootstrapped yesterday's SVN on this platform: Linux fencepost 2.6.16.29-xen #1 SMP Wed Dec 6 07:32:36 EST 2006 x86_64 GNU/Linux > For a patch like this only the libiberty testsuite need be run. After a successful bootstrap, I typed "make -C libiberty check", and the test ran to completion without any errors. Here's again the patch I suggest (this time including the removal of 2 obsolete Awk scripts). As I don't have write access, could someone please commit it? Thanks. 2009-04-16 Eli Zaretskii * Makefile.in (needed-list): Target removed (not used in GCC 3.0 and later). All references deleted. (mostlyclean): Remove references to needed.awk and needed2.awk. --- libiberty/Makefile.in~ 2009-04-15 14:07:06.825412329 -0400 +++ libiberty/Makefile.in 2009-04-15 15:15:03.574853288 -0400 @@ -100,7 +100,7 @@ SUBDIRS = testsuite # FIXME: add @BUILD_INFO@ once we're sure it works for everyone. -all: stamp-picdir $(TARGETLIB) needed-list required-list all-subdir +all: stamp-picdir $(TARGETLIB) required-list all-subdir @: $(MAKE) ; exec $(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=all .PHONY: check installcheck @@ -377,22 +377,6 @@ mv -f $(DESTDIR)$(tooldir)/lib/$(MULTIOSDIR)/$(TARGETLIB)n $(DESTDIR)$(tooldir)/lib/$(MULTIOSDIR)/$(TARGETLIB) @$(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=install -# needed-list is used by libstdc++. NEEDED is the list of functions -# to include there. Do not add anything LGPL to this list; libstdc++ -# can't use anything encumbering. -NEEDED = atexit calloc memchr memcmp memcpy memmove memset rename strchr \ - strerror strncmp strrchr strstr strtol strtoul tmpnam vfprintf vprintf \ - vfork waitpid bcmp bcopy bzero -needed-list: Makefile - rm -f needed-list; touch needed-list; \ - for f in $(NEEDED); do \ - for g in $(LIBOBJS) $(EXTRA_OFILES); do \ - case "$$g" in \ - *$$f*) echo $$g >> needed-list ;; \ - esac; \ - done; \ - done - # required-list was used when building a shared bfd/opcodes/libiberty # library. I don't know if it used by anything currently. required-list: Makefile @@ -440,8 +424,8 @@ # multiple times, hence our explicit recursion with an empty SUBDIRS. mostlyclean: mostlyclean-subdir -rm -rf *.o pic core errs \#* *.E a.out - -rm -f needed.awk needed2.awk errors dummy needed-list config.h stamp-* - -rm -f $(CONFIG_H) $(NEEDED_LIST) stamp-picdir + -rm -f errors dummy config.h stamp-* + -rm -f $(CONFIG_H) stamp-picdir -rm -f libiberty.aux libiberty.cp libiberty.cps libiberty.fn libiberty.ky -rm -f libiberty.log libiberty.tmp libiberty.tps libiberty.pg -rm -f libiberty.pgs libiberty.toc libiberty.tp libiberty.tpl libiberty.vr