From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67746-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32602 invoked by alias); 16 Oct 2009 18:44:41 -0000
Received: (qmail 32373 invoked by uid 22791); 16 Oct 2009 18:44:40 -0000
X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Oct 2009 18:44:35 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KRM00000EMRJJ00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 16 Oct 2009 20:44:10 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.117.47]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KRM00KE3EPLI2A0@a-mtaout20.012.net.il>; Fri, 16 Oct 2009 20:44:10 +0200 (IST)
Date: Fri, 16 Oct 2009 18:44:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][doc] PR python/10781
In-reply-to: <m37huvjjqy.fsf@fleche.redhat.com>
To: tromey@redhat.com
Cc: pmuldoon@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <8363afi3hf.fsf@gnu.org>
References: <4AD82247.3070503@redhat.com> <838wfbixtf.fsf@gnu.org> <m37huvjjqy.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00369.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Cc: Phil Muldoon <pmuldoon@redhat.com>, gdb-patches@sourceware.org
> Date: Fri, 16 Oct 2009 12:07:01 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> +Cast the @code{gdb.Value} to the type represented by @var{type}, and
> Eli>         ^^^
> Eli> Please remove this "the".
> 
> Removing the "the" makes this read strangely.
> gdb.Value is a class, the "the" indicates that it is an instance which is
> cast.

Then how about "Cast an instance of @code{gdb.Value} ..."?

> >> +return a new @code{gdb.Value}.  @var{type} must be a @code{gdb.Type}
> >> +object.
> 
> Eli> If TYPE is an object, then it probably isn't a good idea to call it
> Eli> TYPE.  Why not OBJECT?
> 
> I think it is generally preferable to name parameters according to their
> use.

No, they should be named according to their essence, i.e. what they
are.

> "object" is not specific enough.

I'm open to other suggestions.

> Eli> Anyway, what does it mean "the type represented by TYPE"?  How can a
> Eli> type be "represented"?  Did you perhaps mean "the type of TYPE"?
> 
> gdb.Type represents a type in the inferior.

Sorry, I still don't understand.