From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6056 invoked by alias); 4 Mar 2013 18:15:25 -0000 Received: (qmail 6038 invoked by uid 22791); 4 Mar 2013 18:15:24 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL,TW_QB X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Mar 2013 18:15:09 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MJ500500ENQEL00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 04 Mar 2013 20:14:43 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MJ50056REOJDL20@a-mtaout20.012.net.il>; Mon, 04 Mar 2013 20:14:43 +0200 (IST) Date: Mon, 04 Mar 2013 18:15:00 -0000 From: Eli Zaretskii Subject: Re: [patch v9 23/23] btrace, remote: drop qbtrace packet In-reply-to: <1362416770-19750-24-git-send-email-markus.t.metzger@intel.com> To: Markus Metzger Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org, markus.t.metzger@gmail.com, palves@redhat.com Reply-to: Eli Zaretskii Message-id: <836217t4kz.fsf@gnu.org> References: <1362416770-19750-1-git-send-email-markus.t.metzger@intel.com> <1362416770-19750-24-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00125.txt.bz2 > From: Markus Metzger > Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com, > Pedro Alves , Eli Zaretskii > Date: Mon, 4 Mar 2013 18:06:10 +0100 > > Use the qXfer:btrace:read packet's annex to encode a trace read method: > > all ... read all trace > new ... read all trace if the trace has changed > > This obsoletes the need for the qbtrace packet. > > CC: Pedro Alves > CC: Jan Kratochvil > CC: Eli Zaretskii > > 2013-03-04 Markus Metzger > > * target.h (target_ops) : Add type parameter. > (target_ops) : Remove. > (target_btrace_has_changed): Remove. > (target_read_btrace): Add type parameter. > * target.c (target_read_btrace): Add type parameter. > (target_btrace_has_changed): Remove. > * remote.c (PACKET_qbtrace): Remove. > (remote_protocol_features): Remove qbtrace. > (remote_supports_btrace): Remove check for qbtrace. > (remote_btrace_has_changed): Remove. > (remote_read_btrace): Consider read type. > (init_remote_ops): Remove to_disable_btrace. > (_initialize_remote): Remove qbtrace. > * i386-linux-nat.c (_initialize_i386_linux_nat): Remove > initialization of to_btrace_has_changed. > * common/linux-btrace.h (linux_read_btrace): Add type parameter. > (linux_btrace_has_changed): Removed. > * common/linux-btrace.c (linux_btrace_has_changed): Moved. > Changed to static. > (linux_read_btrace): Consider read type. > * common/btrace-common.h (btrace_read_type): New enum. > * btrace.c (btrace_fetch): Only update branch trace if it > changed. > * amd64-linux-nat.c (_initialize_amd64_linux_nat): Remove > initialization of to_btrace_has_changed. > > gdbserver/ > > * target.h (target_ops): Remove btrace_has_changed. Add type > parameter to read_btrace. Update target_ macros. > * server.c: Include btrace-common.h. > (handle_qxfer_btrace): Consider read type in annex. > (handle_btrace_query): Removed. > (handle_query): Remove qbtrace from qSupported. Remove call to > handle_btrace_query. > * linux-low.c (linux_low_read_btrace): Consider read type. > (linux_target_ops): Remove linux_btrace_has_changed. > > doc/ > > * gdb.texinfo (Remote Configuration): Remove qbtrace. > Describe annex of Qbtrace. OK for the documentation part. Thanks.