From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1238 invoked by alias); 22 Aug 2013 15:09:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1224 invoked by uid 89); 22 Aug 2013 15:09:54 -0000 X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.2 Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 22 Aug 2013 15:09:52 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MRX00100TY4QT00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 22 Aug 2013 18:09:50 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MRX0018OU4CRI00@a-mtaout22.012.net.il>; Thu, 22 Aug 2013 18:09:49 +0300 (IDT) Date: Thu, 22 Aug 2013 15:09:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v2] Added file properties to windows gdb executable for all mingw32 builds. In-reply-to: <1377161766-8318-1-git-send-email-bernd.bunk@intel.com> To: Bernd Bunk Cc: tromey@redhat.com, palves@redhat.com, gdb-patches@sourceware.org, bernd.bunk@intel.com Reply-to: Eli Zaretskii Message-id: <8361uxkbi9.fsf@gnu.org> References: <1377161766-8318-1-git-send-email-bernd.bunk@intel.com> X-SW-Source: 2013-08/txt/msg00642.txt.bz2 > From: Bernd Bunk > Cc: gdb-patches@sourceware.org, Bernd Bunk > Date: Thu, 22 Aug 2013 10:56:06 +0200 > > On Windows OS it is customary that executables and DLL's show file properties. > These contain product name/version, file name/version, company/copyright info. > File properties are visible by right-click on the file, selecting properties \ details. > This patch adds file properties to the gdb executable for all mingw builds. Thanks, this looks OK to me, except for a couple of comments: > * Makefile.in (win_exe_properties.h): Add rule to create > win_exe_properties.h header file with file property information. > (win_exe_properties.o): Added rule to build the resource file. > * configure: Add win_exe_properties.o to mingw32 specific > objects. > * common/create-win_exe_properties.sh: Shell script to > create a win_exe_properties.h header file containing all > information/defines for the gdb executable file properties. > New file. > * win_exe_properties.rc: Resource file implementing > gdb executable file properties for windows/mingw32 builds. > It includes auto-generated win_exe_properties.h file with > property information. New file. New files you add should say "New file". Also, please leave two spaces between sentences, the US style. The GNU project doesn't like calling Windows a "win", so I suggest to rename the files and the script to use something like mingw instead. > +# check for environment variables to replace certain file properties > +[ -n "$WIN_EXE_VERSION" ] && version=$WIN_EXE_VERSION > +[ -n "$WIN_EXE_COMPANY_NAME" ] && company_name=$WIN_EXE_COMPANY_NAME > +[ -n "$WIN_EXE_FILE_DESCRIPTION" ] && file_description=$WIN_EXE_FILE_DESCRIPTION > +[ -n "$WIN_EXE_PRODUCT_NAME" ] && product_name=$WIN_EXE_PRODUCT_NAME > +[ -n "$WIN_EXE_INTERNAL_NAME" ] && internal_name=$WIN_EXE_INTERNAL_NAME > +[ -n "$WIN_EXE_ORIGINAL_FILENAME" ] && original_filename=$WIN_EXE_ORIGINAL_FILENAME > +[ -n "$WIN_EXE_COPYRIGHT" ] && copyright=$WIN_EXE_COPYRIGHT > +[ -n "$WIN_EXE_LICENSE" ] && license=$WIN_EXE_LICENSE > +[ -n "$WIN_EXE_CONFIGURED" ] && configured=$WIN_EXE_CONFIGURED > +[ -n "$WIN_EXE_SUPPORT" ] && support=$WIN_EXE_SUPPORT This looks like unnecessary featurism to me. Is it really needed, and if so, in what use cases? > +#include "afxres.h" Is this header really needed? Thanks.