From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8022 invoked by alias); 17 Mar 2014 16:44:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8012 invoked by uid 89); 17 Mar 2014 16:44:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout23.012.net.il Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Mar 2014 16:44:38 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N2L00700A53D300@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Mon, 17 Mar 2014 18:44:36 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N2L007W0AIBBD30@a-mtaout23.012.net.il>; Mon, 17 Mar 2014 18:44:36 +0200 (IST) Date: Mon, 17 Mar 2014 16:44:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 6/8] go32-nat.c: Don't override to_open. In-reply-to: <1395069784-7406-7-git-send-email-palves@redhat.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <8361ncbwqu.fsf@gnu.org> References: <1395069784-7406-1-git-send-email-palves@redhat.com> <1395069784-7406-7-git-send-email-palves@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00381.txt.bz2 > From: Pedro Alves > Date: Mon, 17 Mar 2014 15:23:02 +0000 > > Although the string says "Done.", nothing is pushing the target as is. > Removing the method override let's us fall through to the the base > to_open implemention in inf-child.c, which will push the target in > reaction to "target native" in a follow up patch. > > gdb/ > 2014-03-17 Pedro Alves > > * go32-nat.c (go32_open): Delete. > (go32_target): Don't override the to_open method. OK.