From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32555 invoked by alias); 4 Apr 2014 09:16:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32539 invoked by uid 89); 4 Apr 2014 09:16:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout22.012.net.il Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Apr 2014 09:16:28 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N3I0020014GEN00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 04 Apr 2014 12:16:26 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3I002G41RDDG30@a-mtaout22.012.net.il>; Fri, 04 Apr 2014 12:16:26 +0300 (IDT) Date: Fri, 04 Apr 2014 09:16:00 -0000 From: Eli Zaretskii Subject: Re: [rfc] btrace: control memory access during replay In-reply-to: <1396601781-25010-1-git-send-email-markus.t.metzger@intel.com> To: Markus Metzger Cc: palves@redhat.com, jan.kratochvil@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <8361mpa1z9.fsf@gnu.org> References: <1396601781-25010-1-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00057.txt.bz2 > From: Markus Metzger > Cc: gdb-patches@sourceware.org, Eli Zaretskii > Date: Fri, 4 Apr 2014 10:56:21 +0200 > > The btrace record target does not trace data. We therefore do not allow > accessing read-write memory during replay. > > In some cases, this might be useful to advanced users, though, who we assume > to know what they are doing. > > Add a set|show command pair to turn this memory access restriction off. > > CC: Eli Zaretskii > > 2014-04-04 Markus Metzger > > * record-btrace.c (set_record_btrace_cmdlist) > (show_record_btrace_cmdlist, cmd_set_record_btrace) > (cmd_show_record_btrace): New. > (_initialize_record_btrace): Add commands. > * NEWS: Announce it. > > testsuite/ > * gdb.btrace/data.exp: Test it. > > doc/ > * gdb.texinfo: Document it. The ChangeLog entry should state the name(s) of the node(s) in which you make changes. Other than that, the documentation parts are approved. However, I wonder whether "allow-memory-access" is a good name for a setting which actually allows access to writable portion of the memory. IOW, even when the value is OFF, we do allow access to memory, just not the writable portion of it. Thanks.