From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58852 invoked by alias); 11 Sep 2015 12:30:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58842 invoked by uid 89); 11 Sep 2015 12:30:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout22.012.net.il Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Sep 2015 12:30:26 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NUI00F00IIYDX00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 11 Sep 2015 15:30:24 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NUI00FUOIQN2E80@a-mtaout22.012.net.il>; Fri, 11 Sep 2015 15:30:24 +0300 (IDT) Date: Fri, 11 Sep 2015 12:30:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 7/7] Support tracepoints and software breakpoints on ARM aarch32-linux in GDBServer. In-reply-to: <1441973603-15247-8-git-send-email-antoine.tremblay@ericsson.com> To: Antoine Tremblay Cc: gdb-patches@sourceware.org, antoine.tremblay@ericsson.com Reply-to: Eli Zaretskii Message-id: <83613h3zqf.fsf@gnu.org> References: <1441973603-15247-1-git-send-email-antoine.tremblay@ericsson.com> <1441973603-15247-8-git-send-email-antoine.tremblay@ericsson.com> X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00229.txt.bz2 > From: Antoine Tremblay > CC: Antoine Tremblay > Date: Fri, 11 Sep 2015 08:13:23 -0400 > > diff --git a/gdb/NEWS b/gdb/NEWS > index 0cf51e1..085d844 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,10 @@ > > *** Changes since GDB 7.10 > > +* Support for tracepoints on aarch32-linux was added in GDBServer. > + > +* Support for software breakpoints on aarch32-linux was added in GDBServer. > + > * Support for tracepoints on aarch64-linux was added in GDBserver. > > * The 'record instruction-history' command now indicates speculative execution This is OK. > -@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:X@var{len},@var{bytes}]@r{[}-@r{]} > +@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:X@var{len},@var{bytes}][:K@var{kind}]@r{[}-@r{]} > @cindex @samp{QTDP} packet > Create a new tracepoint, number @var{n}, at @var{addr}. If @var{ena} > is @samp{E}, then the tracepoint is enabled; if it is @samp{D}, then > -the tracepoint is disabled. The @var{step} gives the tracepoint's step > -count, and @var{pass} gives its pass count. If an @samp{F} is present, > -then the tracepoint is to be a fast tracepoint, and the @var{flen} is > -the number of bytes that the target should copy elsewhere to make room > -for the tracepoint. If an @samp{X} is present, it introduces a > -tracepoint condition, which consists of a hexadecimal length, followed > -by a comma and hex-encoded bytes, in a manner similar to action > -encodings as described below. If the trailing @samp{-} is present, > -further @samp{QTDP} packets will follow to specify this tracepoint's > -actions. > +the tracepoint is disabled. The @var{step} gives the tracepoint's > +step count, and @var{pass} gives its pass count. If an @samp{F} is > +present, then the tracepoint is to be a fast tracepoint, and the > +@var{flen} is the number of bytes that the target should copy > +elsewhere to make room for the tracepoint. If an @samp{X} is present, > +it introduces a tracepoint condition, which consists of a hexadecimal > +length, followed by a comma and hex-encoded bytes, in a manner similar Please in the future try not to re-fill previous text: it makes harder for me to find your changes among a potentially large paragraph, such as this one. > +to action encodings as described below. If a @samp{K} is present, it > +indicates a target specific breakpoint length. E.g., the arm and mips > +can insert either a 2 or 4 byte breakpoint. Some architectures have > +additional meanings for kind see : @ref{Architecture-Specific Protocol > +Details} . There's no need for the colon ':' after "see", and please delete the space before the period that ends the last sentence above. Otherwise, the documentation parts are OK. Thanks.