From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16254 invoked by alias); 8 Feb 2017 17:34:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16042 invoked by uid 89); 8 Feb 2017 17:34:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1626 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Feb 2017 17:34:06 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbW83-0005OA-SZ for gdb-patches@sourceware.org; Wed, 08 Feb 2017 12:34:04 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbW7l-0005LM-Sp; Wed, 08 Feb 2017 12:33:45 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2966 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cbW7k-0008D0-US; Wed, 08 Feb 2017 12:33:45 -0500 Date: Wed, 08 Feb 2017 17:34:00 -0000 Message-Id: <8360kk60zn.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org, palves@redhat.com, lgustavo@codesourcery.com In-reply-to: <20170208032257.15443-7-sergiodj@redhat.com> (message from Sergio Durigan Junior on Tue, 7 Feb 2017 22:22:57 -0500) Subject: Re: [PATCH v3 6/6] Implement proper "startup-with-shell" support on gdbserver Reply-to: Eli Zaretskii References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170208032257.15443-1-sergiodj@redhat.com> <20170208032257.15443-7-sergiodj@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00198.txt.bz2 > From: Sergio Durigan Junior > Cc: Pedro Alves , Luis Machado , Sergio Durigan Junior > Date: Tue, 7 Feb 2017 22:22:57 -0500 > > diff --git a/gdb/NEWS b/gdb/NEWS > index 21e8cd3..f26e95e 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,13 @@ > > *** Changes since GDB 7.12 > > +* GDBserver is now able to start inferiors using a shell. When using > + "target extended-remote", the host GDB honors the value of "set > + startup-with-shell" in order to inform GDBserver whether the remote > + inferior should be started with a shell or not. When using "target > + remote", it is possible to disable the startup with shell by using > + the new parameter "--no-startup-with-shell" when starting GDBserver. > + > * Building GDB and GDBserver now requires a C++11 compiler. > > For example, GCC 4.8 or later. > @@ -367,6 +374,9 @@ show max-value-size > > * New remote packets > > +QStartupWithShell > + Indicates whether the inferior must be started with a shell or not. > + > exec stop reason > Indicates that an exec system call was executed. This part is OK. > +If @var{value} is @var{0}, @command{gdbserver} will not use a shell to > +start the inferior. If @var{value} is @var{1}, @command{gdbserver} "0" and "1" should be in @samp, not @var, because they are literal symbols. > +@item E @var{nn} > +An error occurred. The error number @var{nn} is give as hex digits. ^^^^ "given" Documentation patch is OK with those minor issues fixed. Thanks.