From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68619 invoked by alias); 12 Apr 2017 14:58:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67972 invoked by uid 89); 12 Apr 2017 14:58:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 14:58:18 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyJip-00027x-1M for gdb-patches@sourceware.org; Wed, 12 Apr 2017 10:58:18 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyJio-00027s-Ui; Wed, 12 Apr 2017 10:58:14 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4433 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cyJio-0001JA-8R; Wed, 12 Apr 2017 10:58:14 -0400 Date: Wed, 12 Apr 2017 14:58:00 -0000 Message-Id: <8360i9k6zp.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org In-reply-to: <1fa86b25-7201-bdbc-8494-e4262fcc9d5e@redhat.com> (message from Pedro Alves on Wed, 12 Apr 2017 15:45:59 +0100) Subject: Re: [PATCH] gdb: Move DJGPP/go32 bits to their own tdep file Reply-to: Eli Zaretskii References: <1492003875-25394-1-git-send-email-palves@redhat.com> <83bms1ka9s.fsf@gnu.org> <838tn5k7pu.fsf@gnu.org> <1fa86b25-7201-bdbc-8494-e4262fcc9d5e@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00342.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Wed, 12 Apr 2017 15:45:59 +0100 > > On 04/12/2017 03:42 PM, Eli Zaretskii wrote: > >> Cc: gdb-patches@sourceware.org > >> From: Pedro Alves > >> Date: Wed, 12 Apr 2017 15:07:02 +0100 > >> > >>> The comment in i386-tdep.c says: > >>> > >>> /* There are a few i386 architecture variants that differ only > >>> slightly from the generic i386 target. For now, we don't give them > >>> their own source file, but include them here. As a consequence, > >>> they'll always be included. */ > >>> > >>> If we are going to have a separate tdep file for such architectures, > >>> let's do it for SVR4 as well. > >> > >> That can be done, but I don't see why it has to be in the same patch? > > > > It doesn't. > > So to be clear, are you OK with the patch as is? Yes. Sorry if it wasn't clear.