From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53232 invoked by alias); 14 May 2017 14:13:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53214 invoked by uid 89); 14 May 2017 14:13:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=modest X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 14 May 2017 14:13:54 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9uHQ-0002yD-Vm for gdb-patches@sourceware.org; Sun, 14 May 2017 10:13:56 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9uHQ-0002y1-Rv; Sun, 14 May 2017 10:13:52 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1931 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d9uHP-00082m-W5; Sun, 14 May 2017 10:13:52 -0400 Date: Sun, 14 May 2017 14:13:00 -0000 Message-Id: <8360h38r1r.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: <91d9fc6cc7c07674a0b5cd02e7b1502b@polymtl.ca> (message from Simon Marchi on Sat, 13 May 2017 23:19:06 -0400) Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c Reply-to: Eli Zaretskii References: <20170504194442.63AAF60B72@joel.gnat.com> <83o9v3cs25.fsf@gnu.org> <91d9fc6cc7c07674a0b5cd02e7b1502b@polymtl.ca> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00317.txt.bz2 > Date: Sat, 13 May 2017 23:19:06 -0400 > From: Simon Marchi > Cc: gdb-patches@sourceware.org > > > How best to solve this? I worked around by providing my own > > implementation based on std::ostringstream, but I'm not sure this is > > TRT. An alternative would be to use some less problematic API, since > > currently cli-script.c is the only user of this method, and its needs > > are quite modest. And if we do provide a replacement for to_string, > > should the configure script probe for it, or should we condition it > > specifically on MinGW and _GLIBCXX_HAVE_BROKEN_VSWPRINTF? > > > > Thoughts? > > I think the best solution would be a check at configure time. I think > it's a function that can be quite handy, so it would be unfortunate if > we had to avoid using it, especially if it's easy to implement ourselves > for MinGW. A configure check would be more robust than checking for > MinGW or _GLIBCXX_HAVE_BROKEN_VSWPRINTF specifically, in case another > platform needs the replacement too, or if the define changes at some > point. I've meanwhile learned that the latest release 5.0 of MinGW runtime solves this problem.