Re: [PATCH] Fix testsuite hangs when gdb_test_multiple body errors out (Re: GDB 8.2.90 available for testing)

Pedro Franco de Carvalho
2019-03-22T20:44:40Z

Pedro Alves <palves@redhat.com> writes:

Hello,

> I spent a while trying to fix this, and I came up with the patch below.
>
> WDYT?

Makes sense to me.

> So this commit solves this by appending an "eof" with an empty
> spawn_id list, so that it won't ever match.

This is a clever solution, but just to be sure, can we actually rely on
this behavior when the list is empty? This did work when I tested it,
but could some Expect version conceivably do something else like
returning an error when parsing a body with a "-i" that uses an empty
list?

> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>

I think you meant gdb/testsuite/ChangeLog

Thanks for the patch!

--
Pedro Franco de Carvalho