From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43686 invoked by alias); 31 Mar 2019 14:28:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43675 invoked by uid 89); 31 Mar 2019 14:28:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS,URIBL_BLOCKED autolearn=ham version=3.3.1 spammy=84, precisely, 8.4, Restore X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 31 Mar 2019 14:28:50 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAbS2-000279-D9; Sun, 31 Mar 2019 10:28:46 -0400 Received: from [176.228.60.248] (port=4215 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hAbS1-00034U-6N; Sun, 31 Mar 2019 10:28:45 -0400 Date: Sun, 31 Mar 2019 14:28:00 -0000 Message-Id: <835zrzi0d7.fsf@gnu.org> From: Eli Zaretskii To: Philippe Waroquiers , Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <1553942211.1854.2.camel@skynet.be> (message from Philippe Waroquiers on Sat, 30 Mar 2019 11:36:51 +0100) Subject: Re: Still some style problems with 8.3 branch References: <1553942211.1854.2.camel@skynet.be> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00775.txt.bz2 > From: Philippe Waroquiers > Date: Sat, 30 Mar 2019 11:36:51 +0100 > > I just encountered a styling problem with the 8.3 branch > (also on the 8.4). > Test executed with GNU gdb (GDB) 8.2.91.20190330-git > > To reproduce: > ./gdb/gdb ./gdb/gdb > info sources > and then type return successively, to see each page. > After the initial page, the first line contains a file that > is partially printed in green color, partially printed in black color, > e.g., in the below given output. > The line that starts with '--Type ' is in black, as expected. > Then the next line starts in green as expected. > But only '/bd/home/ph' is in green. > We then have 'ilippe/gdb/git/relbranch/gdb/minsyms.h,' in black. > Then all is normal till the next page. > > So, that seems to point at some remaining problem in the > buffering/output of style/color codes. I don't think it's due to buffering. If I #ifdef away this part near the end of prompt_for_continue: /* Restore the current styling. */ if (can_emit_style_escape (gdb_stdout)) emit_style_escape (applied_style); then the problem seems to go away. So I think this style setting is what causes the problem, probably because applied_style has the wrong value here? The incorrect style seems to start precisely from the first character that exceeds the last column of a line, so I think it's indeed due to the above snippet. Tom, can you look into this, please?