From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12809 invoked by alias); 19 Dec 2019 15:00:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12644 invoked by uid 89); 19 Dec 2019 15:00:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPAM_URI,SPF_PASS autolearn=no version=3.3.1 spammy=likes, sk:sourcew, our X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 15:00:15 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ihxHZ-0004iK-Qy; Thu, 19 Dec 2019 10:00:05 -0500 Received: from [176.228.60.248] (port=4130 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ihxHX-0001td-Dh; Thu, 19 Dec 2019 10:00:04 -0500 Date: Thu, 19 Dec 2019 15:00:00 -0000 Message-Id: <835zic2wer.fsf@gnu.org> From: Eli Zaretskii To: Christian Biesinger CC: brobecker@adacore.com, gdb-patches@sourceware.org In-reply-to: (message from Christian Biesinger on Wed, 18 Dec 2019 14:19:18 -0600) Subject: Re: GDB 9.0.90 available for testing References: <20191211214745.E1CF0838D4@joel.gnat.com> <83tv604239.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00815.txt.bz2 > From: Christian Biesinger > Date: Wed, 18 Dec 2019 14:19:18 -0600 > Cc: Joel Brobecker , gdb-patches > > On Mon, Dec 16, 2019 at 11:23 AM Eli Zaretskii wrote: > > 2. readline/colors.c fails to compile because it uses the likes of > > S_IXGRP and S_IXOTH, which aren't defined in MinGW. The solution > > is to patch readline/posixstat.h to add the missing defines (it > > tries to do so, but makes assumptions that don't do a perfect job). > > FWIW, I've reported this at https://osdn.net/projects/mingw/ticket/39856 Thanks. > I would suggest patching readline locally and also sending a patch > upstream; that's what I did in > http://sourceware-org.1504.n7.nabble.com/PATCH-readline-Fix-compilation-on-MinGW-td585030.html I've now reported the problem to Readline developers. Should I go ahead and patch our local copy, or should I wait for the Readline developers to respond?