From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id L6B8Cekth2K5NQcAWB0awg (envelope-from ) for ; Fri, 20 May 2022 01:58:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 188CE1E220; Fri, 20 May 2022 01:58:01 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=XAlc9YtL; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 916AB1E143 for ; Fri, 20 May 2022 01:58:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9ABC83835439 for ; Fri, 20 May 2022 05:57:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9ABC83835439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1653026279; bh=l2wqI6aEBwkZkYPdlEQ76Civ1BwwukjFiIcqJ92Nc5Y=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XAlc9YtLZPOPA6oqxITydxW154eILY7miwpZDXb+/mrx7XIbPiwxxnXeqluvfoiaS lYw2BqaJ2Qk9dt0tKAWAQqafKUpGdqUFAOXGhTenxL2guD6pZrKp6eOTz9rnd23+A/ YI7fnfuSq+awuEP1+1+ohtUBvn5sfZranSCsb+Xc= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 585DF3835419 for ; Fri, 20 May 2022 05:57:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 585DF3835419 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49114) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrvdm-0000Bw-2v; Fri, 20 May 2022 01:57:34 -0400 Received: from [87.69.77.57] (port=4453 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrvdk-0006pi-Gd; Fri, 20 May 2022 01:57:32 -0400 Date: Fri, 20 May 2022 08:57:31 +0300 Message-Id: <835ym0d9v8.fsf@gnu.org> To: Pedro Alves In-Reply-To: <20220519215552.3254012-1-pedro@palves.net> (message from Pedro Alves on Thu, 19 May 2022 22:55:50 +0100) Subject: Re: [PATCH 0/2] info breakpoints improvements References: <20220519215552.3254012-1-pedro@palves.net> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: Pedro Alves > Date: Thu, 19 May 2022 22:55:50 +0100 > > we get: > > (top-gdb) info breakpoints > Num Type Disp Enb Address What > 1 breakpoint keep y internal_error > 1.1 y 0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 2 breakpoint keep y -qualified internal_error > 2.1 y 0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 3 breakpoint keep y errors.c:54 > 3.1 y 0x00000000005755a5 in internal_error(char const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 3.2 y 0x00007ffff6d50410 in PyErr_SetObject at /usr/src/debug/python2-2.7.15-4.fc27.x86_64/Python/errors.c:54 > 4 breakpoint keep y gdb.c:27 > 4.1 y 0x000055555564107b in main(int, char**) at src/gdb/gdb.c:28 > (top-gdb) I must confess that the new display is much more cluttered, and includes redundant information, so it's harder to read. It also makes the important stuff harder to find. Why exactly is this deemed as improvement, and in particular, why would we want this behavior as the default? (I won't mind to have this as opt-in behavior, if someone finds this useful in some situations.) > Patch #2 introduces an "info breakpoints -hide-locations" option. > With that, you get just the breakpoint header rows, showing the > canonical location spec originally used to set the breakpoint, but not > what the spec expanded to: > > (top-gdb) i b -h > Num Type Disp Enb What > 1 breakpoint keep y internal_error > 2 breakpoint keep y -qualified internal_error > 3 breakpoint keep y errors.c:54 If we want a concise display that only shows the important parts, I'd lose the "Disp" column. Thanks.