From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130014 invoked by alias); 10 Nov 2016 23:19:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130001 invoked by uid 89); 10 Nov 2016 23:19:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:965 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Nov 2016 23:19:48 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5FF3668B2; Thu, 10 Nov 2016 23:19:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAANJkW4029512; Thu, 10 Nov 2016 18:19:46 -0500 Subject: Re: [RFA 16/20] Use gdbpy_enter in gdbpy_get_matching_xmethod_workers To: Tom Tromey , gdb-patches@sourceware.org References: <1478816387-27064-1-git-send-email-tom@tromey.com> <1478816387-27064-17-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <8356ffb0-722d-c6fb-c063-e18c24b3ccab@redhat.com> Date: Thu, 10 Nov 2016 23:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1478816387-27064-17-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00275.txt.bz2 On 11/10/2016 10:19 PM, Tom Tromey wrote: > @@ -221,26 +210,21 @@ gdbpy_get_matching_xmethod_workers > py_progspace = pspace_to_pspace_object (current_program_space); > if (py_progspace != NULL) > { > - PyObject *temp = py_xmethod_matcher_list; > - PyObject *pspace_matchers = pspy_get_xmethods (py_progspace, NULL); > + gdbpy_reference pspace_matchers (pspy_get_xmethods (py_progspace, NULL)); > > - py_xmethod_matcher_list = PySequence_Concat (temp, pspace_matchers); > - Py_DECREF (temp); > - Py_DECREF (pspace_matchers); I'm a little confused here. Don't we still need to account for these two Py_DECREFs? > - if (py_xmethod_matcher_list == NULL) > + gdbpy_reference temp (PySequence_Concat (py_xmethod_matcher_list.get (), > + pspace_matchers.get ())); > + if (temp == NULL) > { > gdbpy_print_stack (); > - do_cleanups (cleanups); > - > return EXT_LANG_RC_ERROR; -- Thanks, Pedro Alves