From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70102-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19361 invoked by alias); 9 Feb 2010 18:47:24 -0000
Received: (qmail 19353 invoked by uid 22791); 9 Feb 2010 18:47:23 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Feb 2010 18:47:15 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KXL003007I6I400@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 09 Feb 2010 20:47:08 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.67.249]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KXL0022Z86G2E70@a-mtaout22.012.net.il>; Tue, 09 Feb 2010 20:47:05 +0200 (IST)
Date: Tue, 09 Feb 2010 18:47:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: PATCH: Cache types from target description
In-reply-to: <20100209154513.GA27404@lucon.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gdb-patches@sourceware.org, mark.kettenis@xs4all.nl
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834olqdz66.fsf@gnu.org>
References: <20100205011447.GA28263@lucon.org> <20100208185454.GA21449@lucon.org> <20100209154513.GA27404@lucon.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00261.txt.bz2

> Date: Tue, 9 Feb 2010 07:45:13 -0800
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> Cc: GDB <gdb-patches@sourceware.org>, 	Mark Kettenis <mark.kettenis@xs4all.nl>
> 
> Here is the updated patch. I fixed i386_eflags and documented them.
> OK to install?

The doco part is okay, but please fix the following 2 minor issues
before committing:

> 2010-02-09  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* gdb.texinfo: Add i387_ext, i386_eflags and i386_mxcsr.

Please state the name of the node in which you are making the change
(in parens, as if it were a function).  You can find it by looking
back from the locus of the change for a line that begins with
"@node".

> +@item i386_eflags
> +32bit EFLAGS register used by x86.
> +
> +@item i386_mxcsr
> +32bit MXCSR register used by x86.

It would look prettier in print if you use @sc{eflags} and @sc{mxcsr}
instead of up-casing them in the Texinfo sources.

Thanks.