From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71534-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6525 invoked by alias); 29 Mar 2010 06:40:12 -0000
Received: (qmail 6508 invoked by uid 22791); 29 Mar 2010 06:40:10 -0000
X-SWARE-Spam-Status: No, hits=2.8 required=5.0 	tests=BAYES_00,RCVD_IN_JMF_BL,RCVD_IN_SORBS_WEB,SARE_SUB_OBFU_Q1,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Mar 2010 06:40:03 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0L01003006DGT300@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 29 Mar 2010 09:38:52 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.127.176.135]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L01003L76GRE110@a-mtaout20.012.net.il>; Mon, 29 Mar 2010 09:38:52 +0300 (IDT)
Date: Mon, 29 Mar 2010 06:40:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: PATCH: Add xmlRegisters= to qsupported query
In-reply-to: <20100328234643.GA25607@intel.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834ojz3a4d.fsf@gnu.org>
References: <20100328204807.GA10649@intel.com> <20100328205207.GA11401@intel.com> <20100328234643.GA25607@intel.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00979.txt.bz2

> Date: Sun, 28 Mar 2010 16:46:43 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> 
> 2010-03-28  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* gdb.texinfo (General Query Packets): Add xmlRegisters.

I have a few comments to the documentation part:

> +@item xmlRegisters
> +This feature indicates that @value{GDBN} supports supports the XML
                                            ^^^^^^^^^^^^^^^^^
two "supports" in a row.

> +target description.  If the stub sees @samp{xmlRegisters=} with
> +target specfic strings separated by comma, it can send @value{GDBN}
                                    ^^^^^^^^
"by a comma".  Also, what do you mean by "it can send", why "can"?
Doesn't it always send the XML description?

> @@ -5943,6 +5944,9 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>    set_gdbarch_fast_tracepoint_valid_at (gdbarch,
>  					i386_fast_tracepoint_valid_at);
>  
> +  /* Tell remote stub that we support XML target description.  */
> +  register_remote_support_xml ("x86");

A possibly dumb question: what effect will this change in i386-tdep.c
have on i386 targets that don't support remote debugging?  How about
if GDB was built without libexpat?