From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73137-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17182 invoked by alias); 20 May 2010 18:04:38 -0000
Received: (qmail 17150 invoked by uid 22791); 20 May 2010 18:04:37 -0000
X-SWARE-Spam-Status: No, hits=-0.7 required=5.0	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 May 2010 18:04:31 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0L2Q00900CUA0L00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 20 May 2010 21:04:29 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.127.33.125]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L2Q000G7CVFMNP0@a-mtaout20.012.net.il>; Thu, 20 May 2010 21:04:28 +0300 (IDT)
Date: Thu, 20 May 2010 18:04:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] add support for disabling individual pretty-printers
In-reply-to: <20100520071212.E4A8484398@ruffy.mtv.corp.google.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834oi2qwjw.fsf@gnu.org>
References: <20100520071212.E4A8484398@ruffy.mtv.corp.google.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00430.txt.bz2

> Date: Thu, 20 May 2010 00:12:12 -0700 (PDT)
> From: dje@google.com (Doug Evans)
> 
> The approach below uses the presence of an "enabled" attribute
> on the lookup function (or callable object!) to control the
> enabling/disabling.

Thanks.

> +@node Disabling Pretty-Printers
> +@subsubsection Disabling Pretty-Printers

Please put here a @cindex entry for this subject (you can use the
section name, lower-cased, as its text).

> +Pretty-printers are enabled and disabled by attaching an @code{enabled}
> +attribute to the registered function or callable object.  If this attribute
> +is present and its value is @code{False} the printer is disabled, otherwise
> +the printer is enabled.                 ^

A comma missing here.

The patch for the manual is okay with these changes.