From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81983-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8519 invoked by alias); 3 Jul 2011 18:15:55 -0000
Received: (qmail 8510 invoked by uid 22791); 3 Jul 2011 18:15:55 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Jul 2011 18:15:40 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LNR00700RHRYL00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sun, 03 Jul 2011 21:13:56 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.228.8.216]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LNR007WTRZ6MGB0@a-mtaout20.012.net.il>; Sun, 03 Jul 2011 21:13:56 +0300 (IDT)
Date: Sun, 03 Jul 2011 21:13:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
In-reply-to: <CAA18ubJ10sh3pPDLp4V44qY6r6hLU9RqyDi62KuAAtfXJY7Oug@mail.gmail.com>
To: iam ahal <hal9000ed2k@gmail.com>
Cc: pmuldoon@redhat.com, tromey@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834o33qlm9.fsf@gnu.org>
References: <BANLkTinD+9_Mkug8o2VhZ03L6XSriL_RKQ@mail.gmail.com> <m3oc1kfheh.fsf@redhat.com> <20110627160029.GF20676@adacore.com> <m3sjqt67pe.fsf@fleche.redhat.com> <m3mxh1oa8a.fsf@redhat.com> <CAA18ubJ10sh3pPDLp4V44qY6r6hLU9RqyDi62KuAAtfXJY7Oug@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00078.txt.bz2

> Date: Sun, 3 Jul 2011 20:34:55 +0400
> From: iam ahal <hal9000ed2k@gmail.com>
> Cc: Tom Tromey <tromey@redhat.com>, Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
> 
> +@item backtrace nopath
> +@itemx bt nopath
> +It's similar to @code{backtrace}, but print without full path to file.

I would remove the "It's" part, it's redundant and not very
English-like.

But a larger concern is that GNU coding standards frown on using
"path" when you really mean "file name".  So I think we should rename
the option "basename" and the documentation should say

  Same as @code{backtrace}, but print only the basename of the file.

> +      if (print_what == LOC_NO_FULLPATH)
> +	{
> +	  filename = strrchr (sal.symtab->filename, '/');

This is non-portable (directory separator is not guaranteed to be
'/'), you need to use lbasename instead.