Re: [patch+7.5] auto-load: User conveniences suggested by Doug Evans

Eli Zaretskii
2012-08-21T17:50:58Z

> Date: Tue, 21 Aug 2012 16:43:55 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Doug Evans <dje@google.com>
>
> according to user feedback after gdb-7.5 with the auto-load feature considered
> by users as pain I have implemented various backward compatible extensions
> suggested by Doug.

Thanks!

> + if (!advice_printed)
> + {
> + const char *homedir = getenv ("HOME");
> + char *homeinit;
> +
> + if (homedir == NULL)
> + homedir = "$HOME";

This should fall back on $USERPROFILE or on $APPDATA on MS-Windows if
$HOME is not defined. $USERPROFILE/$APPDATA are Windows equivalents
of $HOME, but some Windows users (including yours truly) set $HOME to
another directory (e.g., I don't like having my precious files on a
system disk, because disasters strike there more frequently).

> + printf_filtered (_("\
> +To enable execution of this file add \"add-auto-load-safe-path %s\" \
> +line to \"%s\".\n\

Suggest to move the "add-auto-load-safe-path" part to a new line,
because the file name displayed after that will probably overflow the
terminal line.

> + scripts_directory_help = xstrprintf (_("\
> +Automatically loaded %s%s%sGDB scripts\n\
> +(named OBJFILE%s) are located in one of the directories listed by this\n\
> +option.\n\
> +This option is ignored for the kinds of scripts \
> +having 'set auto-load ... off'.\n\
> +Directories listed here need to be present also \
> +in the 'set auto-load safe-path'\n\
> +option."),

Here, the lines are unnecessarily too short, IMO.

> -Set the list of directories from which it is safe to auto-load files."), _("\
> -Show the list of directories from which it is safe to auto-load files."), _("\
> +Set the list of paths from which it is safe to auto-load files."), _("\
> +Show the list of paths from which it is safe to auto-load files."), _("\

Why "paths" instead of directories? GNU Coding Standards frown on
using "paths" with this semantics.

If the problem is that these can be both files and directories, let's
say "list of files and directories that are safe for auto-loading".

Thanks.