From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30304 invoked by alias); 24 Dec 2012 03:41:24 -0000 Received: (qmail 30256 invoked by uid 22791); 24 Dec 2012 03:41:24 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Dec 2012 03:41:19 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MFI00A00N5NR000@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Mon, 24 Dec 2012 05:41:17 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFI00A87NKTML70@a-mtaout23.012.net.il>; Mon, 24 Dec 2012 05:41:17 +0200 (IST) Date: Mon, 24 Dec 2012 03:41:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if statement In-reply-to: To: Andreas Schwab Cc: pierre.muller@ics-cnrs.unistra.fr, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <834njcp160.fsf@gnu.org> References: <001201cde13f$af3ad4b0$0db07e10$%muller@ics-cnrs.unistra.fr> <837go8pnxn.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00796.txt.bz2 > From: Andreas Schwab > Cc: Pierre Muller , gdb-patches@sourceware.org > Date: Sun, 23 Dec 2012 23:28:45 +0100 > > Eli Zaretskii writes: > > > Since when is that bad C, so much so that we would need to enforce it? > > It's part of the GNU coding standards. Which says "Try not to...". FWIW, Emacs sources are replete with such assignments, and I don't see anything wrong with that in the first place. So yes, I guess I'm challenging this ARI rule.