From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99400-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31223 invoked by alias); 11 Mar 2013 17:05:13 -0000
Received: (qmail 31209 invoked by uid 22791); 11 Mar 2013 17:05:12 -0000
X-SWARE-Spam-Status: No, hits=-4.4 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Mar 2013 17:04:59 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MJI00D009SRUY00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Mon, 11 Mar 2013 19:04:55 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MJI00D26A47P4B0@a-mtaout21.012.net.il>; Mon, 11 Mar 2013 19:04:55 +0200 (IST)
Date: Mon, 11 Mar 2013 17:05:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 5/7] range stepping: New command 'maint set range stepping'
In-reply-to: <1363006291-13334-6-git-send-email-yao@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834nghx3yn.fsf@gnu.org>
References: <1363006291-13334-1-git-send-email-yao@codesourcery.com> <1363006291-13334-6-git-send-email-yao@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00476.txt.bz2

> From: Yao Qi <yao@codesourcery.com>
> Date: Mon, 11 Mar 2013 20:51:29 +0800
> 
> +@kindex maint set range-stepping
> +@kindex maint show range-stepping
> +@cindex range-stepping
> +@item maint set range-stepping
> +@itemx maint show range-stepping
> +Control whether to do stepping in an address range.

Why is this a maintenance command?

Anyway, the documentation part is OK.

> +  add_setshow_boolean_cmd ("range-stepping", class_maintenance,
> +			   &use_range_stepping, _("\
> +Enable or disable range-stepping."), _("\
> +Show whether range-stepping is enabled."), _("\
> +If On, GDB will tell the target to do stepping a range of address.\n\

I suggest

 If ON, GDB will send a single packet to a target telling it to keep
 single-stepping as long as PC is inside a certain range of addresses.

> +This will speed up stepping a line of source file.\n\
> +If off, GDB will not use it, even if such is supported by the \n\

"will not use this feature".  "It" is ambiguous here.

Thanks.